[PHPBB3-11476] Remove pass-by-reference from phpbb_db_driver::sql_multi_insert - phpBB Tracker

XML

Word

Printable

Details

Type: Task
Status: Unverified Fix (View Workflow)
Priority: Major
Resolution: Fixed
Affects Version/s: 3.1.0-dev
Fix Version/s: 3.1.0-a1
Component/s: Database Abstraction Layer (DBAL)
Labels:
None

GitHub Pull Request URL:
https://github.com/phpbb/phpbb3/pull/1320

Description

The method never writes to the array passed by reference. This seems to have been a pseudo-optimisation that causes problems like https://github.com/phpbb/phpbb3/pull/1315/files#r3547996.

Attachments

Activity

People

Assignee:: Joas Schilling

Reporter:: Andreas Fischer [X] (Inactive)

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 27/Mar/13 1:21 PM

Updated:: 27/Mar/13 4:56 PM

Resolved:: 27/Mar/13 4:56 PM