Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-11459

Deduplicate database schema definiton

    Details

    • Type: Task
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-dev
    • Fix Version/s: 3.1.0-b2
    • Component/s: None
    • Labels:
      None

      Description

      create_schema_files.php and migrations contain redundant data.

        Issue Links

          Activity

          Hide
          imkingdavid David King added a comment -

          Would the proper solution then be to make create_schema_files.php use the migration files?

          Show
          imkingdavid David King added a comment - Would the proper solution then be to make create_schema_files.php use the migration files?
          Hide
          EXreaction EXreaction [X] (Inactive) added a comment -

          They don't actually contain redundant data. Create schema files contains a build of the tables as they are now, migrations contain the updates to the schema since 3.0.0.

          The way to fix this would be to add another earlier migration with schema from 3.0.0, then create a parser that understands the interface of db_tools to go through all the migration files and compile the schema changes into a single array.

          Show
          EXreaction EXreaction [X] (Inactive) added a comment - They don't actually contain redundant data. Create schema files contains a build of the tables as they are now, migrations contain the updates to the schema since 3.0.0. The way to fix this would be to add another earlier migration with schema from 3.0.0, then create a parser that understands the interface of db_tools to go through all the migration files and compile the schema changes into a single array.
          Hide
          naderman Nils Adermann added a comment -

          This doesn't need to block A1.

          Show
          naderman Nils Adermann added a comment - This doesn't need to block A1.
          Hide
          EXreaction EXreaction [X] (Inactive) added a comment -

          Does anyone have any ideas on how to make a system to do this for us? I do not have any which seem easy.

          Show
          EXreaction EXreaction [X] (Inactive) added a comment - Does anyone have any ideas on how to make a system to do this for us? I do not have any which seem easy.
          Hide
          EXreaction EXreaction [X] (Inactive) added a comment -

          If nobody has an idea as to how to solve this, I'd say this is a won't fix.

          Show
          EXreaction EXreaction [X] (Inactive) added a comment - If nobody has an idea as to how to solve this, I'd say this is a won't fix.
          Hide
          nickvergessen Joas Schilling added a comment -

          I started some work on this. However develop/create_schema_files.php now requires a db connection, so I don't know whether that's where we want to go, but feel free to take a look:
          https://github.com/nickvergessen/phpbb/compare/ticket;11459

          Andreas Fischer Nils Adermann EXreaction [X]

          Show
          nickvergessen Joas Schilling added a comment - I started some work on this. However develop/create_schema_files.php now requires a db connection, so I don't know whether that's where we want to go, but feel free to take a look: https://github.com/nickvergessen/phpbb/compare/ticket;11459 Andreas Fischer Nils Adermann EXreaction [X]
          Hide
          nickvergessen Joas Schilling added a comment -

          Forgot to make 3.0.1-rc1 depend on 3.0.0

          Show
          nickvergessen Joas Schilling added a comment - Forgot to make 3.0.1-rc1 depend on 3.0.0

            People

            • Assignee:
              nickvergessen Joas Schilling
              Reporter:
              bantu Andreas Fischer
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development