Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-11457

class phpbb_notification_test should not require/use the global set_var() function

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-dev
    • Fix Version/s: 3.1.0-a1
    • Component/s: Notification System
    • Labels:
      None

      Description

      ... because set_var is deprecated in 3.1.

        Activity

        Hide
        bantu Andreas Fischer added a comment -

        Doesn't seem to be used.

        afischer@leonard:/var/www/projects/phpbb3 (ticket/11457) $ cd phpBB
        afischer@leonard:/var/www/projects/phpbb3 (ticket/11457) phpBB $ grep "set_var(" . -Ri | grep -v "\~"
        ./includes/request/type_cast_helper_interface.php:	public function set_var(&$result, $var, $type, $multibyte = false);
        ./includes/request/type_cast_helper_interface.php:	public function recursive_set_var(&$var, $default, $multibyte);
        ./includes/request/type_cast_helper.php:	public function set_var(&$result, $var, $type, $multibyte = false, $trim = true)
        ./includes/request/type_cast_helper.php:	public function recursive_set_var(&$var, $default, $multibyte, $trim = true)
        ./includes/request/type_cast_helper.php:			$this->set_var($var, $var, $type, $multibyte, $trim);
        ./includes/request/type_cast_helper.php:				$this->set_var($k, $k, $key_type, $multibyte);
        ./includes/request/type_cast_helper.php:				$this->recursive_set_var($v, $default_value, $multibyte, $trim);
        ./includes/request/request.php:			$this->type_cast_helper->recursive_set_var($var, $default, $multibyte);
        ./includes/request/request.php:		$this->type_cast_helper->recursive_set_var($var, $default, $multibyte, $trim);
        ./includes/functions.php:function set_var(&$result, $var, $type, $multibyte = false)
        ./includes/functions.php:	$type_cast_helper->set_var($result, $var, $type, $multibyte);
        ./includes/functions.php:		set_var($username, $username, 'string', true);
        ./includes/functions.php:		set_var($password, $password, 'string', true);
        ./includes/functions.php:		$type_cast_helper->set_var($value, $value, gettype($value), true);
        ./includes/auth/auth_apache.php:		set_var($php_auth_user, $php_auth_user, 'string', true);
        ./includes/auth/auth_apache.php:		set_var($php_auth_pw, $php_auth_pw, 'string', true);
        ./develop/check_flash_bbcodes.php:		set_var($content, $content, 'string', true);
        afischer@leonard:/var/www/projects/phpbb3 (ticket/11457) phpBB $ cd ../tests/
        afischer@leonard:/var/www/projects/phpbb3 (ticket/11457) tests $ grep "set_var(" . -Ri | grep -v "\~"
        ./request/type_cast_helper_test.php:	public function test_simple_recursive_set_var()
        ./request/type_cast_helper_test.php:		$this->type_cast_helper->recursive_set_var($data, '', true);
        ./request/type_cast_helper_test.php:	public function test_nested_recursive_set_var()
        ./request/type_cast_helper_test.php:		$this->type_cast_helper->recursive_set_var($data, array(0 => ''), true);
        ./request/type_cast_helper_test.php:	public function test_simple_untrimmed_recursive_set_var()
        ./request/type_cast_helper_test.php:		$this->type_cast_helper->recursive_set_var($data, '', true, false);
        ./request/type_cast_helper_test.php:	public function test_nested_untrimmed_recursive_set_var()
        ./request/type_cast_helper_test.php:		$this->type_cast_helper->recursive_set_var($data, array(0 => ''), true, false);
        ./notification/notification_test.php:		$this->notifications->set_var('notification_types', $types);
        ./mock/notifications_notification_manager.php:	public function set_var($name, $value)

        Show
        bantu Andreas Fischer added a comment - Doesn't seem to be used. afischer@leonard:/var/www/projects/phpbb3 (ticket/11457) $ cd phpBB afischer@leonard:/var/www/projects/phpbb3 (ticket/11457) phpBB $ grep "set_var(" . -Ri | grep -v "\~" ./includes/request/type_cast_helper_interface.php: public function set_var(&$result, $var, $type, $multibyte = false); ./includes/request/type_cast_helper_interface.php: public function recursive_set_var(&$var, $default, $multibyte); ./includes/request/type_cast_helper.php: public function set_var(&$result, $var, $type, $multibyte = false, $trim = true) ./includes/request/type_cast_helper.php: public function recursive_set_var(&$var, $default, $multibyte, $trim = true) ./includes/request/type_cast_helper.php: $this->set_var($var, $var, $type, $multibyte, $trim); ./includes/request/type_cast_helper.php: $this->set_var($k, $k, $key_type, $multibyte); ./includes/request/type_cast_helper.php: $this->recursive_set_var($v, $default_value, $multibyte, $trim); ./includes/request/request.php: $this->type_cast_helper->recursive_set_var($var, $default, $multibyte); ./includes/request/request.php: $this->type_cast_helper->recursive_set_var($var, $default, $multibyte, $trim); ./includes/functions.php:function set_var(&$result, $var, $type, $multibyte = false) ./includes/functions.php: $type_cast_helper->set_var($result, $var, $type, $multibyte); ./includes/functions.php: set_var($username, $username, 'string', true); ./includes/functions.php: set_var($password, $password, 'string', true); ./includes/functions.php: $type_cast_helper->set_var($value, $value, gettype($value), true); ./includes/auth/auth_apache.php: set_var($php_auth_user, $php_auth_user, 'string', true); ./includes/auth/auth_apache.php: set_var($php_auth_pw, $php_auth_pw, 'string', true); ./develop/check_flash_bbcodes.php: set_var($content, $content, 'string', true); afischer@leonard:/var/www/projects/phpbb3 (ticket/11457) phpBB $ cd ../tests/ afischer@leonard:/var/www/projects/phpbb3 (ticket/11457) tests $ grep "set_var(" . -Ri | grep -v "\~" ./request/type_cast_helper_test.php: public function test_simple_recursive_set_var() ./request/type_cast_helper_test.php: $this->type_cast_helper->recursive_set_var($data, '', true); ./request/type_cast_helper_test.php: public function test_nested_recursive_set_var() ./request/type_cast_helper_test.php: $this->type_cast_helper->recursive_set_var($data, array(0 => ''), true); ./request/type_cast_helper_test.php: public function test_simple_untrimmed_recursive_set_var() ./request/type_cast_helper_test.php: $this->type_cast_helper->recursive_set_var($data, '', true, false); ./request/type_cast_helper_test.php: public function test_nested_untrimmed_recursive_set_var() ./request/type_cast_helper_test.php: $this->type_cast_helper->recursive_set_var($data, array(0 => ''), true, false); ./notification/notification_test.php: $this->notifications->set_var('notification_types', $types); ./mock/notifications_notification_manager.php: public function set_var($name, $value)

          People

          • Assignee:
            bantu Andreas Fischer
            Reporter:
            bantu Andreas Fischer
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development