Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-11451

class phpbb_notification_method_jabber extends phpbb_notification_method_email

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-dev
    • Fix Version/s: 3.1.0-a1
    • Component/s: Notification System
    • Labels:
      None

      Description

      This is suboptimal object-orientiented programming. Both methods should inherit from a common abstract class instead, e.g. phpbb_notification_method_messenger. The intention of doing so seems to be able to reuse the notify() method which uses includes/functions_messenger.

        Issue Links

          Activity

          Hide
          bantu Andreas Fischer added a comment -

          Have to double check that abstract methods are ignored by whatever looks for new methods.

          Show
          bantu Andreas Fischer added a comment - Have to double check that abstract methods are ignored by whatever looks for new methods.
          Hide
          EXreaction EXreaction [X] (Inactive) added a comment -

          The container handles sending a list of available methods/types to the manager (as they are described in the notifications services yml file).

          Show
          EXreaction EXreaction [X] (Inactive) added a comment - The container handles sending a list of available methods/types to the manager (as they are described in the notifications services yml file).

            People

            • Assignee:
              bantu Andreas Fischer
              Reporter:
              bantu Andreas Fischer
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development