Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-11431

All topic notifications are deleted if one reply is edited and needs to be approved

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-dev
    • Fix Version/s: 3.1.0-b3
    • Component/s: Notification System
    • Labels:
      None

      Description

      <nickvergessen> if you add a reply to a topic
      <nickvergessen> subscribers are notifiied?
      <EXreaction> yes
      <nickvergessen> okay
      <nickvergessen> so when another reply is added
      <nickvergessen> the notification is updated?
      <EXreaction> depends; if you've not read it yet, for topic replies, it adds respondents to the notification
      <EXreaction> if you read it, it adds a new notification
      <nickvergessen> no the user didnt visit the board
      <nickvergessen> so what does "adds respondents" mean?
      <EXreaction> a, b, c replied to topic x
      <nickvergessen> okay
      <nickvergessen> so if now the post is edited
      <nickvergessen> you trigger
      <nickvergessen> $phpbb_notifications->delete_notifications('topic', $data['topic_id']);
      <EXreaction> that's only if the post requires approval
      <nickvergessen> yeah
      <nickvergessen> but still
      <EXreaction> yes, with respondents, that could cause an issue; please file a bug ticket
      <nickvergessen> yeah
      <nickvergessen> so im correct that all notifications are deleted
      <nickvergessen> not only the once that should?
      <EXreaction> well, there is only one notification in that situation
      <EXreaction> and it would be deleted
      <nickvergessen> but shouldnt
      <nickvergessen> okay
      <EXreaction> correct, it should be altered
      <nickvergessen> also please note
      <nickvergessen> an unapproved first post
      <nickvergessen> does not mean that the topic is unapproved in softdelete branch/after merge

        Issue Links

          Activity

          Hide
          nickvergessen Joas Schilling added a comment - - edited
          Show
          nickvergessen Joas Schilling added a comment - - edited Bump EXreaction [X]
          Hide
          EXreaction EXreaction [X] (Inactive) added a comment -

          Changing this to major. It's not causing major breakage or anything, just a pretty annoying bug.

          Show
          EXreaction EXreaction [X] (Inactive) added a comment - Changing this to major. It's not causing major breakage or anything, just a pretty annoying bug.
          Hide
          nickvergessen Joas Schilling added a comment -

          Just defeating the whole porpuse of having notifications....

          Show
          nickvergessen Joas Schilling added a comment - Just defeating the whole porpuse of having notifications....

            People

            • Assignee:
              nickvergessen Joas Schilling
              Reporter:
              nickvergessen Joas Schilling
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development