Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-11420

Notification methods are not (correctly) imported

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-dev
    • Fix Version/s: 3.1.0-a1
    • Component/s: Notification System
    • Labels:
      None

      Description

      I am pretty sure area51 users subscribed to forums and topics are no longer getting email notifications because the notification settings are not correctly imported or not imported at all. At least I had to recheck email and jabber settings. This is a major loss of functionality that should be addressed as soon as possible.

        Issue Links

          Activity

          Hide
          bantu Andreas Fischer added a comment - - edited

          Have to import Email/Jabber settings correctly for:

          • Someone replies to a topic to which you are subscribed
          • Someone creates a topic in a forum to which you are subscribed
          • Someone sends you a private message

          Everything else seems to be new and defaulting to in-board notification is fine. Additionally having in-board notification on for the types mentioned above is okay too.

          Show
          bantu Andreas Fischer added a comment - - edited Have to import Email/Jabber settings correctly for: Someone replies to a topic to which you are subscribed Someone creates a topic in a forum to which you are subscribed Someone sends you a private message Everything else seems to be new and defaulting to in-board notification is fine. Additionally having in-board notification on for the types mentioned above is okay too.
          Hide
          EXreaction EXreaction [X] (Inactive) added a comment -

          Andreas, would you be interested in checking this out? The current notifications migration handles this in a function (in the migration file), there must just be something wrong with the function that's causing it to not import properly.

          Show
          EXreaction EXreaction [X] (Inactive) added a comment - Andreas, would you be interested in checking this out? The current notifications migration handles this in a function (in the migration file), there must just be something wrong with the function that's causing it to not import properly.
          Hide
          bantu Andreas Fischer added a comment -

          I just noticed that too. So far so good, will have a look.

          Show
          bantu Andreas Fischer added a comment - I just noticed that too. So far so good, will have a look.
          Hide
          bantu Andreas Fischer added a comment -

          I am not sure you are importing the correct data. user_notify is "Notify me upon replies by default", a setting determining whether a checkbox on posting is checked or not.

          Show
          bantu Andreas Fischer added a comment - I am not sure you are importing the correct data. user_notify is "Notify me upon replies by default", a setting determining whether a checkbox on posting is checked or not.
          Hide
          bantu Andreas Fischer added a comment -

          Just FYI: Having the loops like this is the wrong way around. You are performing the query for every $convert_notifications element, but the data doesn't change.

          		foreach ($convert_notifications as $convert_data)
          		{
          			if ($convert_data['check'])
          			{
          				$sql = 'SELECT user_id, user_notify_type
          					FROM ' . USERS_TABLE;
          				$result = $this->db->sql_query($sql);

          Show
          bantu Andreas Fischer added a comment - Just FYI: Having the loops like this is the wrong way around. You are performing the query for every $convert_notifications element, but the data doesn't change. foreach ($convert_notifications as $convert_data) { if ($convert_data['check']) { $sql = 'SELECT user_id, user_notify_type FROM ' . USERS_TABLE; $result = $this->db->sql_query($sql);

            People

            • Assignee:
              EXreaction EXreaction [X] (Inactive)
              Reporter:
              bantu Andreas Fischer
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development