Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-11403

Multiinsert for notifications should use batches

    Details

      Description

      Currently my DB goes away when notifications for unread posts are added for 20k Users. The problem is they are all added in one query, using sql_multi_insert().
      EXreaction said, the function itself could also split the sets up into batches. (Would avoid duplicated code everywhere)

        Activity

        Hide
        nickvergessen Joas Schilling added a comment -

        This must be a blocker, as it prevents finishing posts on big boards with many subscribers

        Show
        nickvergessen Joas Schilling added a comment - This must be a blocker, as it prevents finishing posts on big boards with many subscribers
        Hide
        EXreaction EXreaction [X] (Inactive) added a comment -

        Yes, it might be required for (extremely) large boards. I'm not sure how many boards have items that thousands of people subscribe to though. The fix for this might depend on DB settings (how long a single query can be), so someone else needs to comment on that part before it could be properly fixed.

        I'm moving the fix version to B1 since this needs info and it should not affect anyone before B1 at the earliest.

        Show
        EXreaction EXreaction [X] (Inactive) added a comment - Yes, it might be required for (extremely) large boards. I'm not sure how many boards have items that thousands of people subscribe to though. The fix for this might depend on DB settings (how long a single query can be), so someone else needs to comment on that part before it could be properly fixed. I'm moving the fix version to B1 since this needs info and it should not affect anyone before B1 at the earliest.
        Hide
        bantu Andreas Fischer added a comment -

        People running large boards should be able to test-upgrade to 3.1-A1 too, so this is a blocker in my opinion. It seems easy to resolve.

        Show
        bantu Andreas Fischer added a comment - People running large boards should be able to test-upgrade to 3.1-A1 too, so this is a blocker in my opinion. It seems easy to resolve.

          People

          • Assignee:
            bantu Andreas Fischer
            Reporter:
            nickvergessen Joas Schilling
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development