Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-11360

page_header() argument "display_online_list" should be FALSE by default

    XMLWordPrintable

Details

    • Improvement
    • Status: Unverified Fix (View Workflow)
    • Minor
    • Resolution: Fixed
    • 3.0.11
    • 3.1.0-b2
    • Other
    • None

    Description

      In /includes/functions.php the function page_header has as 2nd optional argument

      $display_online_list = true

      ...which will gather the online list data. However, this is needed on rather few pages. While the original development of phpBB3 might have had in mind that most of the default files are using this, time has shown that MODs with all their custom pages never use this data at all, yet they never call page_header( ... , FALSE ) to skip unneeded database activity.

      This argument should be FALSE by default and update the 10 spots which would then need a TRUE as 2nd argument. A search thru all files of 3.0.11 gives me 9 spots which actually supply FALSE, while 10 spots use either TRUE or no argument.

      Inspired by http://www.phpbb.com/community/viewtopic.php?f=71&t=2172931

      Attachments

        Activity

          People

            nickvergessen Joas Schilling [X] (Inactive)
            AmigoJack AmigoJack
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: