Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-11346

Do not show "Mark topics as read" when there are no topics

    Details

    • Type: Improvement
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.11, 3.1.0-dev
    • Fix Version/s: 3.1.0-a3
    • Component/s: Viewing forums
    • Labels:
      None

      Description

      The parent could not be easily fixed because the code surrounding the mark topics link differs between the top and bottom of viewforum_body.html.

      Copied from: https://github.com/phpbb/phpbb3/pull/919#issuecomment-12567979
      There are a few differences.
      TOTAL_TOPICS instead of the .topicrow you added
      TOTAL_TOPICS is being displayed in the output if not TOTAL_POSTS (and checks both against "and not NEWEST_USER." I have no idea why this is being done)
      PAGINATION has a if PAGE_NUMBER wrapper around it on the second instance.

      To properly fix this, I think we need to do a few things.
      First, we need to figure out where the two sets of code diverged and why that happened.
      Second, we need change the block so that they are the same for both.

        Activity

        There are no comments yet on this issue.

          People

          • Assignee:
            nickvergessen Joas Schilling
            Reporter:
            EXreaction EXreaction [X] (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development