Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-11342

Marking subforums as read does not change the unread icons of active topics

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-dev
    • Fix Version/s: 3.1.0-a1
    • Component/s: None
    • Labels:
      None

      Description

      When in a forum that has subforums and active topics, if you click the mark forums read option, it correctly changes the forum icons to unread, but active topics are not affected. The topics are marked read, but the icon remains unread. See screenshot.

        Activity

        Hide
        Marc Marc added a comment - - edited

        The link "Mark subforums read" only marks the subforums read (hence being called that). Since the unread topics are not inside the subforums, they are of course not marked as read.

        edit: Never mind, didn't see the "active topics" there ...

        Show
        Marc Marc added a comment - - edited The link "Mark subforums read" only marks the subforums read (hence being called that). Since the unread topics are not inside the subforums, they are of course not marked as read. edit: Never mind, didn't see the "active topics" there ...
        Hide
        Marc Marc added a comment -

        Before I forget it: We should maybe try to find the active topics .forumbg div and run marking those topics read just on that. Finding that div should work with something like this:

        $('.forumbg').find(".icon > dt:contains('Active topics')")

        Where 'Active topics' is of course replaced with the language variable.
        An alternative to this could be that we decide what needs to be done in viewforum.php and then also mark topics read if we are currently watching a category (as that seems to be the only reason active topics actually show).

        Show
        Marc Marc added a comment - Before I forget it: We should maybe try to find the active topics .forumbg div and run marking those topics read just on that. Finding that div should work with something like this: $('.forumbg').find(".icon > dt:contains('Active topics')") Where 'Active topics' is of course replaced with the language variable. An alternative to this could be that we decide what needs to be done in viewforum.php and then also mark topics read if we are currently watching a category (as that seems to be the only reason active topics actually show).
        Hide
        Oleg Oleg [X] (Inactive) added a comment -

        Ideally all selectors used in js should only use js-specific classes.

        See e.g. https://coderwall.com/p/qktuzw.

        Show
        Oleg Oleg [X] (Inactive) added a comment - Ideally all selectors used in js should only use js-specific classes. See e.g. https://coderwall.com/p/qktuzw .

          People

          • Assignee:
            EXreaction EXreaction [X] (Inactive)
            Reporter:
            t_backoff Tabitha Backoff [X] (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development