Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-11323

Not possible to define template variable with other variables

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-dev
    • Fix Version/s: 3.1.0-a1
    • Component/s: Template Engine
    • Labels:
      None

      Description

      With the new template engine a few tests were added. One of those tests actually checks if it's possible to include a file that was defined by a variable; this obviously works.

      Unfortunately, this doesn't work if one tries to define the variable with another variable or a loop variable.

      This used to work until now so this is actually a regression.

      The attached test_loop_define.diff extends the current develop tests and should explain what is not working a little bit better. The file test_loop_define_olympus.diff will add the checks to develop-olympus and will show that the tests actually pass on develop-olympus.

        Issue Links

          Activity

          Hide
          Oleg Oleg [X] (Inactive) added a comment - - edited

          The root cause appears to be the following:

          <!-- DEFINE $DEF = '

          {VARIABLE}

          ' -->

          The variable is not expanded in that statement.

          Show
          Oleg Oleg [X] (Inactive) added a comment - - edited The root cause appears to be the following: <!-- DEFINE $DEF = ' {VARIABLE} ' --> The variable is not expanded in that statement.
          Hide
          Marc Marc added a comment -

          I have added another PR that seems to fix the issue judging by my tests and the unit tests.

          Show
          Marc Marc added a comment - I have added another PR that seems to fix the issue judging by my tests and the unit tests.

            People

            • Assignee:
              EXreaction EXreaction [X] (Inactive)
              Reporter:
              Marc Marc
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development