Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-11320

Database test cases fail if functions file is not included and config file exists

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-dev
    • Fix Version/s: 3.1.0-a1
    • Component/s: Test Suite
    • Labels:
      None

      Description

      phpbb_convert_30_dbms_to_31 is undefined in this situation and an error is thrown.

        Activity

        Hide
        bantu Andreas Fischer added a comment -

        Please provide the actual error messages in the future.

        Show
        bantu Andreas Fischer added a comment - Please provide the actual error messages in the future.
        Hide
        EXreaction EXreaction [X] (Inactive) added a comment -

        Call to undefined function phpbb_convert_30_dbms_to_31 phpbb_test_case_helpers.php line 81

        Show
        EXreaction EXreaction [X] (Inactive) added a comment - Call to undefined function phpbb_convert_30_dbms_to_31 phpbb_test_case_helpers.php line 81
        Hide
        bantu Andreas Fischer added a comment -

        Still not sure how to reproduce this.

        phpunit tests/dbal/select_test.php

        works and so does

        phpunit tests/dbal/write_test.php

        Show
        bantu Andreas Fischer added a comment - Still not sure how to reproduce this. phpunit tests/dbal/select_test.php works and so does phpunit tests/dbal/write_test.php
        Hide
        EXreaction EXreaction [X] (Inactive) added a comment -

        You must be using a test config file and the test must not include the functions.php file itself.

        Show
        EXreaction EXreaction [X] (Inactive) added a comment - You must be using a test config file and the test must not include the functions.php file itself.
        Hide
        bantu Andreas Fischer added a comment -

        Yes. Provide an example of such a test.

        Show
        bantu Andreas Fischer added a comment - Yes. Provide an example of such a test.
        Hide
        EXreaction EXreaction [X] (Inactive) added a comment -

        Looking through the test cases, it looks like phpbb_cache_null_driver_test doesnt include it.

        Show
        EXreaction EXreaction [X] (Inactive) added a comment - Looking through the test cases, it looks like phpbb_cache_null_driver_test doesnt include it.

          People

          • Assignee:
            EXreaction EXreaction [X] (Inactive)
            Reporter:
            EXreaction EXreaction [X] (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development