Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-11302

No timezone is selected by default in registration form

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-dev
    • Fix Version/s: 3.1.0-a1
    • Component/s: None
    • Labels:
      None

      Description

      The list of timezones is restricted to one UTC offset, but there is no actual timezone selected. This is a regression vs 3.0. We should select either the "most common" one or the first one on the list.

        Activity

        Hide
        Marc Marc added a comment -

        This might be related to these JS errors I get on the registration page:

        Uncaught ReferenceError: jQuery is not defined timezone.js:19
        Uncaught ReferenceError: phpbb_preselect_tz_select is not defined ucp.php:274

        Show
        Marc Marc added a comment - This might be related to these JS errors I get on the registration page: Uncaught ReferenceError: jQuery is not defined timezone.js:19 Uncaught ReferenceError: phpbb_preselect_tz_select is not defined ucp.php:274
        Hide
        Marc Marc added a comment -

        I looked at the issue a little bit further. First of, we include timezone.js more than just once. Once in timezone_option.html, which is included in ucp_register.html, and then another time in ucp_register.html itself.
        The actual issue we are having is that we try to use jQuery before it has been included in overall_footer.html.

        Show
        Marc Marc added a comment - I looked at the issue a little bit further. First of, we include timezone.js more than just once. Once in timezone_option.html, which is included in ucp_register.html, and then another time in ucp_register.html itself. The actual issue we are having is that we try to use jQuery before it has been included in overall_footer.html.
        Hide
        Oleg Oleg [X] (Inactive) added a comment -

        The duplicate inclusion sounds like it should be handled by includejs.

        > The actual issue we are having is that we try to use jQuery before it has been included in overall_footer.html.

        If there inline js pasted into markup that tries to run inline, it should be delayed until document is ready. If jquery does not exist for $.ready call, my solution would tend to be an inline counterpart to includejs but apparently there is some opposition to this approach and someone prefers dumping code into a giant switch statement or equivalent in core/ajax.js.

        Show
        Oleg Oleg [X] (Inactive) added a comment - The duplicate inclusion sounds like it should be handled by includejs. > The actual issue we are having is that we try to use jQuery before it has been included in overall_footer.html. If there inline js pasted into markup that tries to run inline, it should be delayed until document is ready. If jquery does not exist for $.ready call, my solution would tend to be an inline counterpart to includejs but apparently there is some opposition to this approach and someone prefers dumping code into a giant switch statement or equivalent in core/ajax.js.
        Hide
        Oleg Oleg [X] (Inactive) added a comment -

        Actually avoiding inline js is probably not a bad idea in the context of phpbb and should be investigated first.

        Practically speaking I'm guessing there will need to be some data attributes added in strategic places and some ajax callbacks to process them.

        Show
        Oleg Oleg [X] (Inactive) added a comment - Actually avoiding inline js is probably not a bad idea in the context of phpbb and should be investigated first. Practically speaking I'm guessing there will need to be some data attributes added in strategic places and some ajax callbacks to process them.

          People

          • Assignee:
            Oleg Oleg [X] (Inactive)
            Reporter:
            Oleg Oleg [X] (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development