Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-11202

Add response status checks to functional tests

    Details

    • Type: Improvement
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.11, 3.1.0-dev
    • Fix Version/s: 3.0.12-RC1, 3.1.0-a1
    • Component/s: Test Suite
    • Labels:
      None

      Description

      Currently functional tests do not check response status, but go straight for content assertions. This means when the entire board is broken this is not immediately obvious. Each request should have a response assertion after it.

        Activity

        Hide
        Oleg Oleg [X] (Inactive) added a comment -
        Show
        Oleg Oleg [X] (Inactive) added a comment - https://github.com/phpbb/phpbb3/pull/1090 for olympus backport.
        Hide
        Oleg Oleg [X] (Inactive) added a comment -

        https://github.com/phpbb/phpbb3/pull/1092 for success responses on develop.

        Non-success responses on develop should still be checked one way or another.

        Show
        Oleg Oleg [X] (Inactive) added a comment - https://github.com/phpbb/phpbb3/pull/1092 for success responses on develop. Non-success responses on develop should still be checked one way or another.
        Hide
        Oleg Oleg [X] (Inactive) added a comment -
        Show
        Oleg Oleg [X] (Inactive) added a comment - Another one: https://github.com/phpbb/phpbb3/pull/1099

          People

          • Assignee:
            Oleg Oleg [X] (Inactive)
            Reporter:
            Oleg Oleg [X] (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development