[PHPBB3-11193] Generalize phpbb_di_pass_collection_pass to handle all collections using service tags

XML

Word

Printable

Details

Type: Improvement
Status: Unverified Fix (View Workflow)
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.1.0-dev
Fix Version/s: 3.1.0-a1
Component/s: Other
Labels:
None

GitHub Pull Request URL:
https://github.com/phpbb/phpbb3/pull/1076

Description

Rather than instantiating a phpbb_di_pass_collection_pass for each collection of services, we should have one collection pass on the compiler which creates all collections.

Attachments

Issue Links

caused

PHPBB3-11194 PHP Notice: Undefined index "tag"

Closed

Activity

People

Assignee:: Nils Adermann

Reporter:: Nils Adermann

Votes:: 0 Vote for this issue

Watchers:: 0 Start watching this issue

Dates

Created:: 11/Nov/12 5:37 PM

Updated:: 11/Nov/12 8:05 PM

Resolved:: 11/Nov/12 8:04 PM