Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-11144

{FORUM_NAME} is not filled in login mask when logging into a password protected forum

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.0.11
    • Fix Version/s: 3.0.12-RC1
    • Component/s: Login, Styles
    • Labels:
      None
    • Environment:
      PHP Version 5.4.4
      Apache/2.4.2 (Win32) OpenSSL/1.0.1c PHP/5.4.4
      FireFox 16.0.1

      Description

      The variable

      {FORUM_NAME}

      in /template/login_forum.html is not filled with a value when seeing login mask wanting to log into a password protected forum.
      To fix that
      find in /includes/functions.php

      $template->assign_vars(array(
      'S_LOGIN_ACTION' => build_url(array('f')),
      'S_HIDDEN_FIELDS' => build_hidden_fields(array('f' => $forum_data['forum_id'])))
      );

      change it to
      $template->assign_vars(array(
      'S_LOGIN_ACTION' => build_url(array('f')),
      'S_HIDDEN_FIELDS' => build_hidden_fields(array('f' => $forum_data['forum_id'])),
      'FORUM_NAME' => $forum_data['forum_name'],
      ));

        Activity

        Hide
        bantu Andreas Fischer added a comment -

        I agree the forum name should be available to the template at that point. However, your patch is incomplete. You have to additionally make sure that forum_name is actually passed in the forum_data array.

        Show
        bantu Andreas Fischer added a comment - I agree the forum name should be available to the template at that point. However, your patch is incomplete. You have to additionally make sure that forum_name is actually passed in the forum_data array.
        Hide
        bantu Andreas Fischer added a comment -

        I also do not like the prosilver solution. The forum name should not be in h2 but in the content in my opinion.

        Show
        bantu Andreas Fischer added a comment - I also do not like the prosilver solution. The forum name should not be in h2 but in the content in my opinion.
        Hide
        bantu Andreas Fischer added a comment - - edited

        FORUM_NAME should probably be removed from the prosilver file for 3.0.12-RC1 and FORUM_NAME should be made available in 3.1-A1 with a proper solution.

        Show
        bantu Andreas Fischer added a comment - - edited FORUM_NAME should probably be removed from the prosilver file for 3.0.12-RC1 and FORUM_NAME should be made available in 3.1-A1 with a proper solution.
        Hide
        Miriam Miriam [X] (Inactive) added a comment -

        Was just a hint. I made sure that the index 'forum_name' is available in the passed arrays (in both cases: viewtopic.php and viewforum.php).
        Btw: The function login_forum_box() doesn't even make sure if the index 'forum_id' exists within the passed array.

        Show
        Miriam Miriam [X] (Inactive) added a comment - Was just a hint. I made sure that the index 'forum_name' is available in the passed arrays (in both cases: viewtopic.php and viewforum.php). Btw: The function login_forum_box() doesn't even make sure if the index 'forum_id' exists within the passed array.
        Hide
        *daniel *daniel added a comment -

        Maybe I'm missing somehing, why is phpBB/includes/ucp/ucp_pm_compose.php being edited?

        Forum name for test forum is coming up: http://phpbbbeta.site90.net/viewforum.php?f=2

        Show
        *daniel *daniel added a comment - Maybe I'm missing somehing, why is phpBB/includes/ucp/ucp_pm_compose.php being edited? Forum name for test forum is coming up: http://phpbbbeta.site90.net/viewforum.php?f=2
        Hide
        nickvergessen Joas Schilling added a comment -

        Because it also uses login_forum_box() when you quote a Post into a PM but are not logged in yet.

        Show
        nickvergessen Joas Schilling added a comment - Because it also uses login_forum_box() when you quote a Post into a PM but are not logged in yet.
        Hide
        *daniel *daniel added a comment -

        Forum name comes up when entering a password protected forum and forum name comes up when sending a PM with quote but not logged into the password protected forum.

        Show
        *daniel *daniel added a comment - Forum name comes up when entering a password protected forum and forum name comes up when sending a PM with quote but not logged into the password protected forum.

          People

          • Assignee:
            bantu Andreas Fischer
            Reporter:
            Miriam Miriam [X] (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development