Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-11099

Clicking Banning tab in MCP causes all tabs to collapse down

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-dev
    • Fix Version/s: 3.1.0-a1
    • Labels:
      None
    • Environment:
      php 5.4.4 Ubuntu 12.04 Firefox 14.0.1 prosilver

      Description

      The title says it all.

      The tabs can be brought back by clicking what little remains of the top of the tab peeking up over the main body. Only happens with that tab.

        Issue Links

          Activity

          Hide
          Oleg Oleg [X] (Inactive) added a comment -

          Is this issue firefox 14-specific?

          Show
          Oleg Oleg [X] (Inactive) added a comment - Is this issue firefox 14-specific?
          Hide
          RMcGirr83 Rich McGirr added a comment -

          This is the error that displays without the edits
          Strict Standards: Non-static method acp_ban::display_ban_options() should not be called statically, assuming $this from incompatible context in C:\xampp\htdocs\phpbb3.git\phpBB\includes\mcp\mcp_ban.php

          PHP version 5.4.7

          Show
          RMcGirr83 Rich McGirr added a comment - This is the error that displays without the edits Strict Standards: Non-static method acp_ban::display_ban_options() should not be called statically, assuming $this from incompatible context in C:\xampp\htdocs\phpbb3.git\phpBB\includes\mcp\mcp_ban.php PHP version 5.4.7
          Hide
          brunoais brunoais added a comment - - edited

          Discussion is needed.
          The variable $this is not used in acp_ban::display_ban_options().
          What's the best approach? Using a static method or keep it as non-static and instantiate the object just to run that method?

          Patch author: Please use the link to the pull request instead of the link to a commit in your own repository for the patch url.

          Show
          brunoais brunoais added a comment - - edited Discussion is needed. The variable $this is not used in acp_ban::display_ban_options(). What's the best approach? Using a static method or keep it as non-static and instantiate the object just to run that method? Patch author: Please use the link to the pull request instead of the link to a commit in your own repository for the patch url.
          Hide
          Oleg Oleg [X] (Inactive) added a comment -

          php 5.4 specific.

          Show
          Oleg Oleg [X] (Inactive) added a comment - php 5.4 specific.
          Hide
          Oleg Oleg [X] (Inactive) added a comment -

          I would as a matter of fact prefer the static version.

          Show
          Oleg Oleg [X] (Inactive) added a comment - I would as a matter of fact prefer the static version.

            People

            • Assignee:
              bantu Andreas Fischer
              Reporter:
              stevemaury stevemaury
            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development