Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-11052

Search class changes not reflected in installer or convertor

          Details

            Description

            When PHPBB3-11011 changed the constructor for the search classes, it was not updated in the installer or convertor. This causes warnings:

            [phpBB Debug] PHP Warning: in file [ROOT]/includes/search/fulltext_native.php on line 45: Missing argument 2 for phpbb_search_fulltext_native::__construct(), called in [ROOT]/install/install_install.php on line 1466 and defined
            		 
            [phpBB Debug] PHP Warning: in file [ROOT]/includes/search/fulltext_native.php on line 45: Missing argument 3 for phpbb_search_fulltext_native::__construct(), called in [ROOT]/install/install_install.php on line 1466 and defined
            		 
            [phpBB Debug] PHP Warning: in file [ROOT]/includes/search/fulltext_native.php on line 45: Missing argument 4 for phpbb_search_fulltext_native::__construct(), called in [ROOT]/install/install_install.php on line 1466 and defined
            		 
            [phpBB Debug] PHP Warning: in file [ROOT]/includes/search/fulltext_native.php on line 45: Missing argument 5 for phpbb_search_fulltext_native::__construct(), called in [ROOT]/install/install_install.php on line 1466 and defined
            		 
            [phpBB Debug] PHP Warning: in file [ROOT]/includes/search/fulltext_native.php on line 45: Missing argument 6 for phpbb_search_fulltext_native::__construct(), called in [ROOT]/install/install_install.php on line 1466 and defined
            		 
            [phpBB Debug] PHP Warning: in file [ROOT]/includes/search/fulltext_native.php on line 45: Missing argument 7 for phpbb_search_fulltext_native::__construct(), called in [ROOT]/install/install_install.php on line 1466 and defined

              Issue Links

              was caused by solution of

              Improvement - An improvement or enhancement to an existing feature or task. PHPBB3-11011 Using dependency injection for global variables in all search backends.

              • Minor - Minor loss of function, or other problem where easy workaround is present.
              • Unverified Fix

                Activity

                Hide
                Permalink
                Noxwizard Patrick Webster added a comment -

                It seems to be missing in other places as well, like the one in /includes/functions_posting.php on line 2373 as seen here: http://area51.phpbb.com/phpBB/viewtopic.php?style=2&p=244137#p244137

                Show
                Noxwizard Patrick Webster added a comment - It seems to be missing in other places as well, like the one in /includes/functions_posting.php on line 2373 as seen here: http://area51.phpbb.com/phpBB/viewtopic.php?style=2&p=244137#p244137

                  People

                  • Assignee:
                    imkingdavid David King
                    Reporter:
                    Noxwizard Patrick Webster
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved:

                      Development