Details

    • Type: Improvement
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-dev
    • Fix Version/s: 3.1.0-a1
    • Component/s: Caching (ACM)
    • Labels:
      None

      Description

      Cache drivers can pretty easily be made to not require the use of global variables. Only phpbb_root_path and phpEx are really used in a few places, and $db is used in one function that can be redesigned to not require $db at all.

        Issue Links

          Activity

          Hide
          EXreaction EXreaction [X] (Inactive) added a comment - - edited

          (after the PR)
          There is now only one location globals are used, in the memory __construct, it uses $dbname and $table_prefix

          Show
          EXreaction EXreaction [X] (Inactive) added a comment - - edited (after the PR) There is now only one location globals are used, in the memory __construct, it uses $dbname and $table_prefix
          Hide
          EXreaction EXreaction [X] (Inactive) added a comment -

          The cache service still uses $db everywhere, and a little more with this PR, but that's another issue.

          Show
          EXreaction EXreaction [X] (Inactive) added a comment - The cache service still uses $db everywhere, and a little more with this PR, but that's another issue.
          Hide
          bantu Andreas Fischer added a comment -

          Merged https://github.com/phpbb/phpbb3/pull/1156 but would like to have architecture changes as per https://github.com/phpbb/phpbb3/issues/934 as well. Maybe in a new ticket.

          Show
          bantu Andreas Fischer added a comment - Merged https://github.com/phpbb/phpbb3/pull/1156 but would like to have architecture changes as per https://github.com/phpbb/phpbb3/issues/934 as well. Maybe in a new ticket.

            People

            • Assignee:
              Oleg Oleg [X] (Inactive)
              Reporter:
              EXreaction EXreaction [X] (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development