Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10966

Remove code duplication from mysql* and mssql* dbal

    Details

      Description

      The mysql/mysqli and mssql/mssql_odbc/mssqlnative dbals have various methods that duplicate each other. Introduce two base classes that are extended by these dbal classes and implements these methods.

        Issue Links

          Activity

          Hide
          nickvergessen Joas Schilling added a comment -

          As per naderman:

          Well it certainly needs to be rebased on top of current develop, but I'm fine with merging this and getting something like @p's SQL dialect classes which separate db library from SQL dialect later on.

          Show
          nickvergessen Joas Schilling added a comment - As per naderman: Well it certainly needs to be rebased on top of current develop, but I'm fine with merging this and getting something like @p's SQL dialect classes which separate db library from SQL dialect later on.
          Hide
          bantu Andreas Fischer added a comment -

          Noxwizard mentioned MSSQL being no longer supported on PHP 5.3. Merging only MySQL changes for now, leaving ticket open to confirm this.

          Show
          bantu Andreas Fischer added a comment - Noxwizard mentioned MSSQL being no longer supported on PHP 5.3. Merging only MySQL changes for now, leaving ticket open to confirm this.
          Hide
          Noxwizard Patrick Webster added a comment -

          PHP has dropped their MSSQL module from 5.3: http://www.php.net/manual/en/intro.mssql.php (ticket)
          The ODBC and Native classes still share some code though, so there should be a base class for it.

          Show
          Noxwizard Patrick Webster added a comment - PHP has dropped their MSSQL module from 5.3: http://www.php.net/manual/en/intro.mssql.php ( ticket ) The ODBC and Native classes still share some code though, so there should be a base class for it.
          Hide
          nickvergessen Joas Schilling added a comment -

          Added a second PR introduces a base for MSSQL

          Show
          nickvergessen Joas Schilling added a comment - Added a second PR introduces a base for MSSQL

            People

            • Assignee:
              nickvergessen Joas Schilling
              Reporter:
              Erik Frèrejean Erik Frèrejean
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development