Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-dev
    • Fix Version/s: 3.1.0-a1
    • Component/s: JavaScript / AJAX
    • Labels:
      None

      Description

      There should be no popup, and unread icons should stop being unread.

        Activity

        Hide
        nickvergessen Joas Schilling added a comment -

        This should be fixed before 3.1 is final, as ajax is wrongly used here.

        Show
        nickvergessen Joas Schilling added a comment - This should be fixed before 3.1 is final, as ajax is wrongly used here.
        Hide
        Marc Marc added a comment -

        I'm not sure what to do with the popup but this small change I quickly made (it's only for the "mark all read" link right now) would at least take care of the refresh:
        https://gist.github.com/4263413

        Getting rid of the overlay message will probably require a change in the PHP file as I wasn't able to get rid of the success message just in javascript.

        Show
        Marc Marc added a comment - I'm not sure what to do with the popup but this small change I quickly made (it's only for the "mark all read" link right now) would at least take care of the refresh: https://gist.github.com/4263413 Getting rid of the overlay message will probably require a change in the PHP file as I wasn't able to get rid of the success message just in javascript.
        Hide
        Marc Marc added a comment -

        Actually, this should take care of the popup message and the refresh:
        https://gist.github.com/4263460

        If that's okay I'll quickly create a patch and open a PR.

        Show
        Marc Marc added a comment - Actually, this should take care of the popup message and the refresh: https://gist.github.com/4263460 If that's okay I'll quickly create a patch and open a PR.
        Hide
        EXreaction EXreaction [X] (Inactive) added a comment - - edited

        I think the intention of ajax is to not reload the page. Otherwise we could do it much more easily just in PHP (either a redirect or just mark the contents read before the page is loaded and display the contents again rather than the trigger_error).

        Show
        EXreaction EXreaction [X] (Inactive) added a comment - - edited I think the intention of ajax is to not reload the page. Otherwise we could do it much more easily just in PHP (either a redirect or just mark the contents read before the page is loaded and display the contents again rather than the trigger_error).
        Hide
        Marc Marc added a comment -

        What do you guys think about this implementation?
        https://github.com/marc1706/phpbb3/compare/ticket;10954

        Show
        Marc Marc added a comment - What do you guys think about this implementation? https://github.com/marc1706/phpbb3/compare/ticket;10954
        Hide
        EXreaction EXreaction [X] (Inactive) added a comment -

        That looks better to me. If you submit a PR I'll test it tonight.

        Show
        EXreaction EXreaction [X] (Inactive) added a comment - That looks better to me. If you submit a PR I'll test it tonight.
        Hide
        Marc Marc added a comment -

        More info in the PR

        Show
        Marc Marc added a comment - More info in the PR

          People

          • Assignee:
            Oleg Oleg [X] (Inactive)
            Reporter:
            callumacrae Callum Macrae
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development