Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10937

Comment removal functions: Backward compatibility broken

    XMLWordPrintable

Details

    Description

      The fix for #10349 changes the way comments are stripped, however backward compatibility gets broken because the COMMENTS key is removed from the $available_dbms array, the remove_remarks() function has been removed and the signature of remove_comments() has been changed (return rather than pass by reference) and finally the function definition of remove_comments has been moved to a different file.

      Attachments

        Issue Links

          blocks

          Task - A task that needs to be done. PHPBB3-10969 Remove remove_comments() and remove_remarks()

          • Major - Major loss of function.
          • Unverified Fix
          is related to

          Task - A task that needs to be done. PHPBB3-10969 Remove remove_comments() and remove_remarks()

          • Major - Major loss of function.
          • Unverified Fix
          was caused by solution of

          Bug - A problem which impairs or prevents the functions of the product. PHPBB3-10349 Unit tests do not remove comments from schemas

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            People

              bantu Andreas Fischer [X] (Inactive)
              Erik Frèrejean Erik Frèrejean
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: