Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10937

Comment removal functions: Backward compatibility broken

    Details

      Description

      The fix for #10349 changes the way comments are stripped, however backward compatibility gets broken because the COMMENTS key is removed from the $available_dbms array, the remove_remarks() function has been removed and the signature of remove_comments() has been changed (return rather than pass by reference) and finally the function definition of remove_comments has been moved to a different file.

        Issue Links

          Activity

          Hide
          naderman Nils Adermann added a comment -

          It was decided that this wasn't a problem as it happens in the installer which will be gone for MODs.

          Can you explain why this is a problem?

          Show
          naderman Nils Adermann added a comment - It was decided that this wasn't a problem as it happens in the installer which will be gone for MODs. Can you explain why this is a problem?
          Hide
          Erik Frèrejean Erik Frèrejean added a comment -

          The Support Toolkit for one relies on these functions and therefore suddenly breaks on a 3.0.11 install. I think that a minor release never should break backward compatibility, just because you don't know which MODs/third party code might rely on these functions/logic.

          Show
          Erik Frèrejean Erik Frèrejean added a comment - The Support Toolkit for one relies on these functions and therefore suddenly breaks on a 3.0.11 install. I think that a minor release never should break backward compatibility, just because you don't know which MODs/third party code might rely on these functions/logic.
          Hide
          bantu Andreas Fischer added a comment -

          How can we fix this with minimal effort?

          Changes to phpBB/install/install_install.php and tests/test_framework/phpbb_database_test_connection_manager.php do not matter.

          Signature of remove_comments() was changed, so a new function name should be used as per https://github.com/phpbb/phpbb3/pull/354/files#r251573

          Then just revert the data array changes to phpBB/includes/functions_install.php and call the new function from remove_remarks(&$sql) and remove_comments(&$output) and we are done?

          Show
          bantu Andreas Fischer added a comment - How can we fix this with minimal effort? Changes to phpBB/install/install_install.php and tests/test_framework/phpbb_database_test_connection_manager.php do not matter. Signature of remove_comments() was changed, so a new function name should be used as per https://github.com/phpbb/phpbb3/pull/354/files#r251573 Then just revert the data array changes to phpBB/includes/functions_install.php and call the new function from remove_remarks(&$sql) and remove_comments(&$output) and we are done?
          Hide
          brunoais brunoais added a comment -

          Nothing to verify.

          Show
          brunoais brunoais added a comment - Nothing to verify.

            People

            • Assignee:
              bantu Andreas Fischer
              Reporter:
              Erik Frèrejean Erik Frèrejean
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development