Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10898

Do not write ?> into config.php to avoid whitespace output

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.10
    • Fix Version/s: 3.0.11-RC1
    • Component/s: Viewing posts
    • Labels:
      None

      Description

      Hi,

      I do not know if we can consider this as a bug but it could be interesting to fix it. The problem is when you have a blank line (\n) after the "?>" in the config.php file, the download/file does not display avatars anymore because a problem of character.

      How to reproduce:

      Just add a blank line after the end of php script "?>" and reload an avatar display.

      Examples:

      With a blank line: (image) http://community.olympe.in/download/file1.php?avatar=121_1337297805.png&header=yes
      With blan line : (binary) http://community.olympe.in/download/file1.php?avatar=121_1337297805.png

      Without blank line (image) http://community.olympe.in/download/file2.php?avatar=121_1337297805.png&header=yes
      Without blank line (binary) http://community.olympe.in/download/file2.php?avatar=121_1337297805.png

      Web observe a small difference between the two binaries at the end (just on char).

      Best regards.
      Sam

        Activity

        Hide
        bantu Andreas Fischer added a comment -

        This problem could be completely avoided by removing "?>" completely from the generated config.php file.

        Show
        bantu Andreas Fischer added a comment - This problem could be completely avoided by removing "?>" completely from the generated config.php file.
        Hide
        olympe olympe added a comment -

        Hi,

        Thanks for your reply. Perfect bugfix.

        Best regards.
        Sam

        Show
        olympe olympe added a comment - Hi, Thanks for your reply. Perfect bugfix. Best regards. Sam
        Hide
        brunoais brunoais added a comment -

        The ?> is not there and all seems correct

        Show
        brunoais brunoais added a comment - The ?> is not there and all seems correct

          People

          • Assignee:
            bantu Andreas Fischer
            Reporter:
            olympe olympe
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development