Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10880

m_approve should not imply f_noapprove

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.10
    • Fix Version/s: 3.0.12-RC1
    • Component/s: None
    • Labels:
      None

      Description

      This is bad because:

      1. It is confusing to users. People wonder why they can post without approval without having the f_noapprove permission.
      2. Permissions are in general not supposed to have any side effects.
      3. It disallows use cases where peer review of post content is required from peer moderators.

        Issue Links

          Activity

          Hide
          bantu Andreas Fischer added a comment -

          This changes behaviour, so maybe 3.1.

          Show
          bantu Andreas Fischer added a comment - This changes behaviour, so maybe 3.1.
          Hide
          Oleg Oleg [X] (Inactive) added a comment -

          I agree.

          If moderators lack f_noapprove then either 1) their permissions are wrong or 2) we should be putting their posts in the queue.

          Anyone disagreeing with this ticket should provide a strong use case for keeping the current logic.

          Show
          Oleg Oleg [X] (Inactive) added a comment - I agree. If moderators lack f_noapprove then either 1) their permissions are wrong or 2) we should be putting their posts in the queue. Anyone disagreeing with this ticket should provide a strong use case for keeping the current logic.
          Hide
          A_Jelly_Doughnut A_Jelly_Doughnut added a comment -

          Yes, their (the moderators without f_noapprove but with m_approve) permissions would be "broken". But I would bet most board admins have their forums with approval set up this way:

          Registered Users Group: Post On Moderation Queue
          Moderator Group: Full Moderator

          Which will produce "broken" permissions, but which would go unnoticed because of current behavior.

          I'd +1 removing the tie between m_approve and f_noapprove, but would suggest the convertor grant f_noapprove to all users/groups with m_approve to emulate the current behavior in a non"broken" way.

          Show
          A_Jelly_Doughnut A_Jelly_Doughnut added a comment - Yes, their (the moderators without f_noapprove but with m_approve) permissions would be "broken". But I would bet most board admins have their forums with approval set up this way: Registered Users Group: Post On Moderation Queue Moderator Group: Full Moderator Which will produce "broken" permissions, but which would go unnoticed because of current behavior. I'd +1 removing the tie between m_approve and f_noapprove, but would suggest the convertor grant f_noapprove to all users/groups with m_approve to emulate the current behavior in a non"broken" way.
          Hide
          nickvergessen Joas Schilling added a comment -

          Needs a PR

          Show
          nickvergessen Joas Schilling added a comment - Needs a PR

            People

            • Assignee:
              Oleg Oleg [X] (Inactive)
              Reporter:
              bantu Andreas Fischer
            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development