Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10839

Remove phpunit.xml.functional and always include functional tests

    Details

    • Type: Task
    • Status: Unverified Fix
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.12, 3.1.0-dev
    • Fix Version/s: 3.0.13-RC1, 3.1.0-b4
    • Component/s: Test Suite
    • Labels:

      Description

      Since we now require PHP 5.3.2, functional tests can always be run. They are already skipped if unconfigured, so this won't require extra configuration for running the same tests as now. To make it simpler we should remove functional tests from the excluded test groups in phpunit.xml.dist so they are always run if configured.

        Issue Links

          Activity

          Hide
          bantu Andreas Fischer added a comment -

          Something to keep in mind here is that the functional part of functional tests may be run as a different user (e.g. www-data) and always running unit tests followed by functional tests may cause permission issues (e.g. with the cache directory) that would have to be handled too.

          Show
          bantu Andreas Fischer added a comment - Something to keep in mind here is that the functional part of functional tests may be run as a different user (e.g. www-data) and always running unit tests followed by functional tests may cause permission issues (e.g. with the cache directory) that would have to be handled too.
          Hide
          nickvergessen Joas Schilling added a comment - - edited

          Shouldn't be a problem at all.
          In phpunit4+ you can:
          phpunit --group functional - to run functional tests
          phpunit --exclude-group functional - to run all but functional tests

          So it should be okay to remove .all and .functional and advice users to use --group slow for all and --exclude-group functional for current .dist

          Show
          nickvergessen Joas Schilling added a comment - - edited Shouldn't be a problem at all. In phpunit4+ you can: phpunit --group functional - to run functional tests phpunit --exclude-group functional - to run all but functional tests So it should be okay to remove .all and .functional and advice users to use --group slow for all and --exclude-group functional for current .dist
          Hide
          bantu Andreas Fischer added a comment -

          In develop-olympus, we are also using PHPUnit 4.1 now (via composer) which requires PHP 5.3.3. Thus we are also having this change in develop-olympus. Travis CI's PHP 5.2 environment has an extra phpunit.xml file for PHPUnit 3.6.

          Show
          bantu Andreas Fischer added a comment - In develop-olympus, we are also using PHPUnit 4.1 now (via composer) which requires PHP 5.3.3. Thus we are also having this change in develop-olympus. Travis CI's PHP 5.2 environment has an extra phpunit.xml file for PHPUnit 3.6.

            People

            • Assignee:
              nickvergessen Joas Schilling
              Reporter:
              naderman Nils Adermann
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development