Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10800

includejs test confusingly includes an html file

    XMLWordPrintable

Details

    • Improvement
    • Status: Unverified Fix (View Workflow)
    • Minor
    • Resolution: Fixed
    • 3.1.0-dev
    • 3.1.0-a1
    • None
    • None

    Description

      includejs test has this code:

      '<script src="' . $dir . '/templates/parent_and_child.html?assets_version=1"></script>',
      '<script src="' . $dir . '/parent_templates/parent_only.html?assets_version=1"></script>',
      '<script src="' . $dir . '/templates/child_only.html?assets_version=1"></script>'

      The tag is intended for javascript. I suggest changing the test to include js files.

      Also $dir is absolute directory. Template tests should use relative directories for templates, just like phpBB does.

      Attachments

        Issue Links

          Activity

            People

              Arty Vjacheslav Trushkin [X] (Inactive)
              Oleg Oleg [X] (Inactive)
              Votes:
              2 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: