Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10800

includejs test confusingly includes an html file

    Details

    • Type: Improvement
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-dev
    • Fix Version/s: 3.1.0-a1
    • Component/s: None
    • Labels:
      None

      Description

      includejs test has this code:

      '<script src="' . $dir . '/templates/parent_and_child.html?assets_version=1"></script>',
      '<script src="' . $dir . '/parent_templates/parent_only.html?assets_version=1"></script>',
      '<script src="' . $dir . '/templates/child_only.html?assets_version=1"></script>'

      The tag is intended for javascript. I suggest changing the test to include js files.

      Also $dir is absolute directory. Template tests should use relative directories for templates, just like phpBB does.

        Issue Links

          Activity

          Hide
          Oleg Oleg [X] (Inactive) added a comment -

          The patch does not address the issue reported in this ticket as it retains html file inclusion.

          I had another ticket open for exposing filesystem paths in output markup (http://tracker.phpbb.com/browse/PHPBB3-10799), did you mean for the patch to fix that?

          Show
          Oleg Oleg [X] (Inactive) added a comment - The patch does not address the issue reported in this ticket as it retains html file inclusion. I had another ticket open for exposing filesystem paths in output markup ( http://tracker.phpbb.com/browse/PHPBB3-10799 ), did you mean for the patch to fix that?
          Hide
          Arty Vjacheslav Trushkin added a comment -

          No, its a different, but related issue. I've added that issue to this ticket because it is related and added commit for original issue to git branch.

          Show
          Arty Vjacheslav Trushkin added a comment - No, its a different, but related issue. I've added that issue to this ticket because it is related and added commit for original issue to git branch.

            People

            • Assignee:
              Arty Vjacheslav Trushkin
              Reporter:
              Oleg Oleg [X] (Inactive)
            • Votes:
              2 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development