Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10799

includejs should not put phpbb root path in generated template code

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Unverified Fix (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-dev
    • Fix Version/s: 3.1.0-a1
    • Component/s: None
    • Labels:
      None

      Description

      In template filter:

      return ' global $phpbb_root_path; $_template->_js_include($phpbb_root_path . \'' . addslashes($filename) . '\', false); ';

      Template already knows the root path (it is even an instance variable in it), therefore there is no need to put it in the generated template code.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Arty Vjacheslav Trushkin [X] (Inactive)
              Reporter:
              Oleg Oleg [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: