Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10772

trigger_error is using the default style

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.11
    • Fix Version/s: 3.0.12-RC1
    • Component/s: Styles
    • Labels:
      None
    • Environment:
      PHP 5.2.4 and 5.3.10, MySQL 5.0.51a and MySQL(i) 5.0.91, all browsers

      Description

      I created a new forum that doesn't use the default style. When browsing through the topics in that forum with the previous/next links, the trigger_error page with "There are no older/newer topics in this forum" reverts back to the default style when it should be using the style I set for that specific forum_id.

        Activity

        Hide
        Arty Vjacheslav Trushkin added a comment -

        Unit tests are in separate pull request

        Show
        Arty Vjacheslav Trushkin added a comment - Unit tests are in separate pull request
        Hide
        Marc Marc added a comment -

        The PR fixes just one trigger_error() case in viewtopic.php. There are several other cases which are not covered by this patch which means it'll still display the wrong style if there is an error and a forum ID is supplied to viewtopic.php.

        Show
        Marc Marc added a comment - The PR fixes just one trigger_error() case in viewtopic.php. There are several other cases which are not covered by this patch which means it'll still display the wrong style if there is an error and a forum ID is supplied to viewtopic.php.
        Hide
        Arty Vjacheslav Trushkin added a comment -

        Possibly. Can you find such cases?

        Show
        Arty Vjacheslav Trushkin added a comment - Possibly. Can you find such cases?
        Hide
        Marc Marc added a comment -

        Well, supplying incorrect topic IDs for example will trigger the incorrect look of trigger_error(). The question is whether we really want to fix a case like that.

        Show
        Marc Marc added a comment - Well, supplying incorrect topic IDs for example will trigger the incorrect look of trigger_error(). The question is whether we really want to fix a case like that.

          People

          • Assignee:
            EXreaction EXreaction [X] (Inactive)
            Reporter:
            marian0810 marian0810
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development