Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10763

Audit code for non-static functions called statically

    Details

    • Type: Task
    • Status: Unverified Fix
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-dev
    • Fix Version/s: 3.1.0-b1
    • Component/s: None
    • Labels:

      Description

      pcregrep -ro '\w+(?<!parent|'"'"')::[a-zA-Z]\w+' phpBB

      phpBB/develop/unicode_testing.php:utf_normalizer::nfkc
      phpBB/develop/unicode_testing.php:utf_normalizer::nfkc
      phpBB/docs/CHANGELOG.html:phpbb_database_test_connection_manager::connect
      phpBB/docs/CHANGELOG.html:session::check_dnsbl
      phpBB/docs/CHANGELOG.html:user::add_lang
      phpBB/docs/CHANGELOG.html:memcache::replace
      phpBB/docs/CHANGELOG.html:memcache::set
      phpBB/docs/CHANGELOG.html:user::page
      phpBB/docs/CHANGELOG.html:user::lang_id
      phpBB/docs/CHANGELOG.html:session::extract_current_page
      phpBB/docs/coding-guidelines.html:user::img
      phpBB/docs/hook_system.html:user::setup
      phpBB/docs/hook_system.html:user::img
      phpBB/feed.php:phpbb_feed_factory::init
      phpBB/includes/acp/acp_captcha.php:phpbb_captcha_factory::get_captcha_types
      phpBB/includes/acp/acp_captcha.php:phpbb_captcha_factory::get_instance
      phpBB/includes/acp/acp_captcha.php:phpbb_captcha_factory::get_instance
      phpBB/includes/acp/acp_captcha.php:phpbb_captcha_factory::get_instance
      phpBB/includes/acp/acp_captcha.php:phpbb_captcha_factory::get_instance
      phpBB/includes/acp/acp_captcha.php:phpbb_captcha_factory::get_instance
      phpBB/includes/acp/acp_jabber.php:jabber::can_use_ssl
      phpBB/includes/acp/acp_language.php:transfer::methods
      phpBB/includes/acp/acp_modules.php_master::module_auth
      phpBB/includes/acp/acp_permission_roles.php:auth_admin::build_permission_array
      phpBB/includes/acp/acp_styles.php:acp_styles::load_css_file
      phpBB/includes/captcha/captcha_gd.php:colour_manager::rgb2hsv
      phpBB/includes/captcha/captcha_gd.php:colour_manager::h2ah
      phpBB/includes/captcha/captcha_gd.php:colour_manager::h2ah
      phpBB/includes/captcha/captcha_gd.php:colour_manager::rgb2hsv
      phpBB/includes/captcha/captcha_gd.php:colour_manager::hsv2rgb
      phpBB/includes/captcha/captcha_gd.php:colour_manager::hsv2rgb
      phpBB/includes/captcha/captcha_gd.php:colour_manager::ah2h
      phpBB/includes/captcha/captcha_gd.php:colour_manager::normalize_hue
      phpBB/includes/captcha/captcha_gd.php:colour_manager::normalize_hue
      phpBB/includes/captcha/captcha_gd.php:colour_manager::ah2h
      phpBB/includes/captcha/captcha_gd.php:colour_manager::normalize_hue
      phpBB/includes/captcha/captcha_gd.php:colour_manager::h2ah
      phpBB/includes/captcha/captcha_gd.php:colour_manager::normalize_hue
      phpBB/includes/captcha/plugins/phpbb_captcha_qa_plugin.php:phpbb_captcha_qa::is_installed
      phpBB/includes/functions.php:config_value::text
      phpBB/includes/functions.php:phpbb_captcha_factory::get_instance
      phpBB/includes/functions.php:user::setup
      phpBB/includes/diff/engine.php:Algorithm::Diff
      phpBB/includes/session.php:phpbb_captcha_factory::garbage_collect
      phpBB/includes/functions_jabber.php:jabber::parse_data
      phpBB/includes/functions_messenger.php:messenger::error
      phpBB/includes/functions_messenger.php:messenger::error
      phpBB/includes/functions_messenger.php:messenger::error
      phpBB/includes/functions_messenger.php:messenger::error
      phpBB/includes/functions_profile_fields.php:user::format_date
      phpBB/includes/functions_transfer.php:transfer::transfer
      phpBB/includes/functions_transfer.php:transfer::transfer
      phpBB/includes/functions_user.php:custom_profile::build_insert_sql_array
      phpBB/includes/functions_user.php:custom_profile::build_insert_sql_array
      phpBB/includes/functions_user.php:fileupload::image_types
      phpBB/includes/functions_user.php:filespec::get_extension
      phpBB/includes/mcp/mcp_ban.php:acp_ban::display_ban_options
      phpBB/includes/search/fulltext_native.php:normalizer::cleanup
      phpBB/includes/search/fulltext_native.php:utf_normalizer::nfc
      phpBB/includes/ucp/ucp_confirm.php:phpbb_captcha_factory::get_instance
      phpBB/includes/ucp/ucp_register.php:phpbb_captcha_factory::get_instance
      pcregrep: line 2 of file phpBB/includes/utf/data/utf_compatibility_decomp.php is too long for the internal buffer
      pcregrep: check the --buffer-size option
      phpBB/includes/utf/utf_normalizer.php:utf_normalizer::recompose
      phpBB/includes/utf/utf_normalizer.php:utf_normalizer::recompose
      phpBB/includes/utf/utf_normalizer.php:utf_normalizer::recompose
      phpBB/includes/utf/utf_normalizer.php:utf_normalizer::decompose
      phpBB/includes/utf/utf_normalizer.php:utf_normalizer::decompose
      phpBB/includes/utf/utf_tools.php:utf_normalizer::cleanup
      phpBB/includes/utf/utf_tools.php:utf_normalizer::nfkc
      phpBB/includes/utf/utf_tools.php:utf_normalizer::nfc
      phpBB/includes/utf/utf_tools.php:utf_normalizer::nfc
      phpBB/includes/utf/utf_tools.php:utf_normalizer::nfc
      phpBB/install/data/confusables.php:utf_new_normalizer::nfkc
      pcregrep: line 648 of file phpBB/install/data/confusables.php is too long for the internal buffer
      pcregrep: check the --buffer-size option
      phpBB/install/data/new_normalizer.php:utf_new_normalizer::nfc
      phpBB/install/data/new_normalizer.php:utf_new_normalizer::nfc
      phpBB/install/data/new_normalizer.php:utf_new_normalizer::nfc
      phpBB/install/data/new_normalizer.php:utf_new_normalizer::recompose
      phpBB/install/data/new_normalizer.php:utf_new_normalizer::recompose
      phpBB/install/data/new_normalizer.php:utf_new_normalizer::recompose
      phpBB/install/data/new_normalizer.php:utf_normalizer::recompose
      phpBB/install/install_update.php:transfer::methods
      phpBB/posting.php:phpbb_captcha_factory::get_instance
      phpBB/style.php:acp_styles::db_theme_data

        Issue Links

          Activity

          Hide
          Oleg Oleg [X] (Inactive) added a comment -

          phpbb_captcha_factory::garbage_collect ought to be a problem, see also http://tracker.phpbb.com/browse/PHPBB3-11157.

          Show
          Oleg Oleg [X] (Inactive) added a comment - phpbb_captcha_factory::garbage_collect ought to be a problem, see also http://tracker.phpbb.com/browse/PHPBB3-11157 .
          Hide
          EXreaction EXreaction [X] (Inactive) added a comment -

          Fix should be for RC1

          Show
          EXreaction EXreaction [X] (Inactive) added a comment - Fix should be for RC1
          Hide
          nickvergessen Joas Schilling added a comment -

          That's what I found at the moment:

          functions_messenger.php
          4x messenger::error();

          functions_transfer.php
          2x transfer::transfer();

          captcha_gd.php
          18x colour_manager::

          new_normalizer.php
          7x utf_normalizer::

          content_visibility.php
          3x self::set_post_visibility()

          Show
          nickvergessen Joas Schilling added a comment - That's what I found at the moment: functions_messenger.php 4x messenger::error(); functions_transfer.php 2x transfer::transfer(); captcha_gd.php 18x colour_manager:: new_normalizer.php 7x utf_normalizer:: content_visibility.php 3x self::set_post_visibility()

            People

            • Assignee:
              nickvergessen Joas Schilling
              Reporter:
              Oleg Oleg [X] (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development