Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10634

cp modules: function loaded() only checks current module type

          Details

            Description

            Function $module->loaded() always prepends current module type to module name. As a result, checking UCP module when p_type is set to 'mcp' is not possible. This bug is caused by resolution of bug #10477.

            Example where UCP modules are being checked while p_type is set to 'mcp': set of module checks in memberlist.php lines 574-578 (mode = 'viewprofile', look for $module->loaded)

              Issue Links

              was caused by solution of

              Bug - A problem which impairs or prevents the functions of the product. PHPBB3-10477 Registration, forgot password broken

              • Blocker - Blocks development and/or testing work, production could not run.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                Oleg Oleg [X] (Inactive) added a comment -

                Any chance we can get some sort of documentation this time around?

                Show
                Oleg Oleg [X] (Inactive) added a comment - Any chance we can get some sort of documentation this time around?
                Hide
                Permalink
                Arty Vjacheslav Trushkin added a comment -

                What kind of documentation?

                Show
                Arty Vjacheslav Trushkin added a comment - What kind of documentation?
                Hide
                Permalink
                Oleg Oleg [X] (Inactive) added a comment -

                You are doing a substr($basename, 1). Why is the first character insignificant? This code does not at all explain what it is doing.

                Documentation: what the legal variable values are, which ones of them are "new" and which ones are provided for backward compatibility, why the new style is different from the old style.

                A regression test would be nice too.

                Show
                Oleg Oleg [X] (Inactive) added a comment - You are doing a substr($basename, 1). Why is the first character insignificant? This code does not at all explain what it is doing. Documentation: what the legal variable values are, which ones of them are "new" and which ones are provided for backward compatibility, why the new style is different from the old style. A regression test would be nice too.
                Hide
                Permalink
                Arty Vjacheslav Trushkin added a comment -

                Changed check to test for phpbb_, ucp_, mcp_ and acp_

                Show
                Arty Vjacheslav Trushkin added a comment - Changed check to test for phpbb_, ucp_, mcp_ and acp_

                  People

                  • Assignee:
                    Arty Vjacheslav Trushkin
                    Reporter:
                    Arty Vjacheslav Trushkin
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved:

                      Development