Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10606

$s_hidden_fields -> incorrect array name (3 files affected)

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.10
    • Fix Version/s: 3.0.11-RC1
    • Component/s: Search
    • Labels:
      None
    • Environment:
      irrelevant

      Description

      phpBB/viewforum.php
      phpBB/viewtopic.php
      phpBB/includes/functions.php

      wrong code:

      if (!empty($_EXTRA_URL))
      {
      	foreach ($_EXTRA_URL as $url_param)
      	{
      		$url_param = explode('=', $url_param, 2);
      		$s_hidden_fields[$url_param[0]] = $url_param[1];
      	}
      }
      

      right code:

      if (!empty($_EXTRA_URL))
      {
      	foreach ($_EXTRA_URL as $url_param)
      	{
      		$url_param = explode('=', $url_param, 2);
      		$s_search_hidden_fields[$url_param[0]] = $url_param[1];
      	}
      }
      

        Issue Links

          Activity

          Hide
          jamesking56 jamesking56 [X] (Inactive) added a comment -

          Pull Request on GitHub

          Show
          jamesking56 jamesking56 [X] (Inactive) added a comment - Pull Request on GitHub
          Hide
          A_Jelly_Doughnut A_Jelly_Doughnut added a comment -

          For testing purposes, please specify the nature of the behavior this error causes (its pretty obvious what it should be)

          Show
          A_Jelly_Doughnut A_Jelly_Doughnut added a comment - For testing purposes, please specify the nature of the behavior this error causes (its pretty obvious what it should be)
          Hide
          bantu Andreas Fischer added a comment -

          A_Jelly_Doughnut: This should cause the same problems as described in http://tracker.phpbb.com/browse/PHPBB3-10319 as this ticket is only fixed partially.

          Show
          bantu Andreas Fischer added a comment - A_Jelly_Doughnut: This should cause the same problems as described in http://tracker.phpbb.com/browse/PHPBB3-10319 as this ticket is only fixed partially.
          Hide
          bantu Andreas Fischer added a comment - - edited

          Okay, it seems like http://tracker.phpbb.com/browse/PHPBB3-10319 was never fixed. The ticket introduced three blocks and all used the wrong variable name. The author of this ticket updated the ticket accordingly.

          Show
          bantu Andreas Fischer added a comment - - edited Okay, it seems like http://tracker.phpbb.com/browse/PHPBB3-10319 was never fixed. The ticket introduced three blocks and all used the wrong variable name. The author of this ticket updated the ticket accordingly.

            People

            • Assignee:
              bantu Andreas Fischer
              Reporter:
              Arni_1 Arni_1 [X] (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development