Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10555

Copyright notice in overall_header.html is not translatable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0, 3.0.1, 3.0.2, 3.0.3, 3.0.4, 3.0.5, 3.0.6, 3.0.7, 3.0.7-PL1, 3.0.8-RC1, 3.0.8, 3.0.9-RC1, 3.0.9-RC2, 3.0.9-RC3, 3.0.9-RC4, 3.0.9
    • Fix Version/s: 3.0.13-RC1, 3.1.0-b1
    • Component/s: Other
    • Labels:
      None

      Description

      <!--
      phpBB style name: prosilver
      Based on style: prosilver (this is the default phpBB3 style)
      Original author: Tom Beddard ( http://www.subBlue.com/ )
      Modified by:

      NOTE: This page was generated by phpBB, the free open-source bulletin board package.
      The phpBB Group is not responsible for the content of this page and forum. For more information
      about phpBB please visit http://www.phpbb.com
      -->

      ^----- from styles/prosilver/template/overall_header.html

      It would be easier for non English users to be able to understand this information.
      We should translate this information.

      If you want, I will provide the solution.

      Regards,
      Ivan Peter Paul
      phpBB Romanian Online Community Team Member
      www.phpbb.ro

        Activity

        Hide
        bantu Andreas Fischer added a comment -

        I think this block should just be removed.

        Show
        bantu Andreas Fischer added a comment - I think this block should just be removed.
        Hide
        ivanpetrepaul Ivan Petre Paul [X] (Inactive) added a comment -

        Why do you think that?
        It shouldn't be removed. It's a part of "copyright" chapter even if the phpBB styles are released under the "GNU Public Licence".
        It must be included in subsilver2 too.

        Additionally, how will we know what style is the theme based on?

        Show
        ivanpetrepaul Ivan Petre Paul [X] (Inactive) added a comment - Why do you think that? It shouldn't be removed. It's a part of "copyright" chapter even if the phpBB styles are released under the "GNU Public Licence". It must be included in subsilver2 too. Additionally, how will we know what style is the theme based on?
        Hide
        doktornotor doktornotor [X] (Inactive) added a comment -

        This is inconsistent with the (just recently fixed) stylesheet.css; namely the "based on style: prosilver... " part makes zero sense. Frankly, there is enough copyright in overall_footer.html and noone reads copyright notices in invisible, commented-out source code.

        Show
        doktornotor doktornotor [X] (Inactive) added a comment - This is inconsistent with the (just recently fixed) stylesheet.css; namely the "based on style: prosilver... " part makes zero sense. Frankly, there is enough copyright in overall_footer.html and noone reads copyright notices in invisible, commented-out source code.
        Hide
        bantu Andreas Fischer added a comment -

        Exactly.

        Show
        bantu Andreas Fischer added a comment - Exactly.
        Hide
        imkingdavid David King added a comment -

        I agree that it should probably be removed.

        Additionally, how will we know what style is the theme based on?

        If it uses lots of tables for layout, it's probably subsilver2-based
        If it uses mostly div tags, it's probably prosilver-based
        Styles in the StylesDB tell what the the style is based on, and most styles in development will have that information in the topic. Additionally, it is often not difficult to tell what the style is based on, just by looking at the style's GUI. And if you really cannot tell, it's still located in the header block of stylesheet.css.

        Show
        imkingdavid David King added a comment - I agree that it should probably be removed. Additionally, how will we know what style is the theme based on? If it uses lots of tables for layout, it's probably subsilver2-based If it uses mostly div tags, it's probably prosilver-based Styles in the StylesDB tell what the the style is based on, and most styles in development will have that information in the topic. Additionally, it is often not difficult to tell what the style is based on, just by looking at the style's GUI. And if you really cannot tell, it's still located in the header block of stylesheet.css.
        Hide
        ivanpetrepaul Ivan Petre Paul [X] (Inactive) added a comment -

        In this case, I agree with you.

        Regards,
        Paul

        Show
        ivanpetrepaul Ivan Petre Paul [X] (Inactive) added a comment - In this case, I agree with you. Regards, Paul
        Hide
        nickvergessen Joas Schilling added a comment -

        The block is removed in 3.0. Closing

        Show
        nickvergessen Joas Schilling added a comment - The block is removed in 3.0. Closing

          People

          • Assignee:
            nickvergessen Joas Schilling
            Reporter:
            ivanpetrepaul Ivan Petre Paul [X] (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development