Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10549

Languages variables should be used, not hardcoded

          Details

          • Type: Improvement
          • Status: Unverified Fix
          • Priority: Minor
          • Resolution: Fixed
          • Affects Version/s: 3.0.12, 3.1.0-a3
          • Fix Version/s: 3.0.13-RC1, 3.1.0-b1
          • Component/s: None
          • Labels:

            Description

            Also I have just noticed (by chance from looking at a diff) that in functions_module.php on Line 452:
            trigger_error('Module not accessible', E_USER_ERROR);
            and Line 460:
            trigger_error("Cannot find module $module_path/{$this->p_name}.$phpEx", E_USER_ERROR);
            and Line 467:
            trigger_error("Module file $module_path/{$this->p_name}.$phpEx does not contain correct class [{$this->p_name}]", E_USER_ERROR);

            Also looking at http://tracker.phpbb.com/browse/PHPBB3-9975 I have a feeling that this could run deeper that a lot of errors don't use language variables.

              Issue Links

              is duplicated by

              Improvement - An improvement or enhancement to an existing feature or task. PHPBB3-11056 Module not accessible in UCP should be translated

              • Minor - Minor loss of function, or other problem where easy workaround is present.
              • Closed

                Activity

                Hide
                Permalink
                Oleg Oleg [X] (Inactive) added a comment - - edited

                Due to the order in which we load components language entries cannot always be used. For example, you need the global $user object to do language lookups, but it is created after global $db object. As a result none of dbal connection functions use language strings.

                I'm tempted to mark this ticket a duplicate of 9975.

                Show
                Oleg Oleg [X] (Inactive) added a comment - - edited Due to the order in which we load components language entries cannot always be used. For example, you need the global $user object to do language lookups, but it is created after global $db object. As a result none of dbal connection functions use language strings. I'm tempted to mark this ticket a duplicate of 9975.

                  People

                  • Assignee:
                    bantu Andreas Fischer
                    Reporter:
                    unknown bliss unknown bliss
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    1 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved:

                      Development