Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10542

Incorrect class="postlink" in styles/subsilver2/template/faq_body.html

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.0.10-RC3
    • Fix Version/s: 3.0.11-RC1
    • Component/s: Styles
    • Labels:
      None

      Description

      <a class="postlink" href="#f

      {faq_block.S_ROW_COUNT}r{faq_block.faq_row.S_ROW_COUNT}">{faq_block.faq_row.FAQ_QUESTION}</a>

      is actually supposed to be

      <a class="postlink-local" href="#f{faq_block.S_ROW_COUNT}

      r

      {faq_block.faq_row.S_ROW_COUNT}

      ">

      {faq_block.faq_row.FAQ_QUESTION}

      </a>

        Activity

        Hide
        bantu Andreas Fischer added a comment -

        This is in subsilver2. But why does it matter? Neither postlink nor postlink-local is defined in CSS.

        Show
        bantu Andreas Fischer added a comment - This is in subsilver2. But why does it matter? Neither postlink nor postlink-local is defined in CSS.
        Hide
        doktornotor doktornotor [X] (Inactive) added a comment -

        Well, because when you use a mod like Prime Links, all the local links are marked as external.

        Show
        doktornotor doktornotor [X] (Inactive) added a comment - Well, because when you use a mod like Prime Links, all the local links are marked as external.
        Hide
        bantu Andreas Fischer added a comment -

        So ... mods have to make this change as well.

        Show
        bantu Andreas Fischer added a comment - So ... mods have to make this change as well.
        Hide
        doktornotor doktornotor [X] (Inactive) added a comment -

        Why? The mod mentioned above is perfectly fine, the only issue is with the FAQ template in subsilver2. See this: http://www.phpbb.com/customise/db/mod/prime_links/support/anchored_internal_links_%28_foo%29_classified_as_external-t_95054-p_234611#p234611

        Show
        doktornotor doktornotor [X] (Inactive) added a comment - Why? The mod mentioned above is perfectly fine, the only issue is with the FAQ template in subsilver2. See this: http://www.phpbb.com/customise/db/mod/prime_links/support/anchored_internal_links_%28_foo%29_classified_as_external-t_95054-p_234611#p234611
        Hide
        nickvergessen Joas Schilling added a comment -

        Post by primehalo:

        Looks like that's a phpbb3 bug. If you look in the includes/functions_content.php file, the make_clickable function shows that the class name for local links should be postlink-local. You may want to submit a bug report.

        Seems legit.

        Show
        nickvergessen Joas Schilling added a comment - Post by primehalo: Looks like that's a phpbb3 bug. If you look in the includes/functions_content.php file, the make_clickable function shows that the class name for local links should be postlink-local. You may want to submit a bug report. Seems legit.
        Hide
        doktornotor doktornotor [X] (Inactive) added a comment -

        Just adding to the above - even making it just completely consistent with prosilver (i.e., specifying no class at all in the FAQ links) like:

        <a href="#f{faq_block.S_ROW_COUNT}r{faq_block.faq_row.S_ROW_COUNT}">{faq_block.faq_row.FAQ_QUESTION}</a>

        makes these issues go away.

        Show
        doktornotor doktornotor [X] (Inactive) added a comment - Just adding to the above - even making it just completely consistent with prosilver (i.e., specifying no class at all in the FAQ links) like: < a href = "#f{faq_block.S_ROW_COUNT}r{faq_block.faq_row.S_ROW_COUNT}" >{faq_block.faq_row.FAQ_QUESTION}</ a > makes these issues go away.
        Hide
        bantu Andreas Fischer added a comment -

        I agree. It is not a postlink because it is not a link in a post. Since the class is nowhere defined in subsilver2, it should just go.

        Show
        bantu Andreas Fischer added a comment - I agree. It is not a postlink because it is not a link in a post. Since the class is nowhere defined in subsilver2, it should just go.
        Hide
        doktornotor doktornotor [X] (Inactive) added a comment -

        All good now.

        Show
        doktornotor doktornotor [X] (Inactive) added a comment - All good now.

          People

          • Assignee:
            bantu Andreas Fischer
            Reporter:
            doktornotor doktornotor [X] (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development