Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10467

Check extensions diff for classes/constants not existing in php 5.2

    Details

    • Type: Task
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-dev
    • Fix Version/s: 3.1.0-a1
    • Component/s: None
    • Labels:
      None

      Description

      https://github.com/phpbb/phpbb3/pull/329 used a class that did not exist in php 5.2, see https://github.com/phpbb/phpbb3/pull/469. The rest of the diff should be checked for similar oversights.

        Activity

        Hide
        Oleg Oleg [X] (Inactive) added a comment -

        (20:23:18) igorw: just went through it again, could not find anything 5.3 specific
        (20:23:39) igorw: the onl thing I'm unsure about is Traversable, but I'm quite certain that's 5.0.0
        (20:24:25) igorw: ok, now I am sure
        (20:24:39) igorw: "Abstract base interface that cannot be implemented alone. Instead it must be implemented by either IteratorAggregate or Iterator." http://ch2.php.net/Traversable
        (20:24:50) igorw: and both of those existin since 5.0.0

        Show
        Oleg Oleg [X] (Inactive) added a comment - (20:23:18) igorw: just went through it again, could not find anything 5.3 specific (20:23:39) igorw: the onl thing I'm unsure about is Traversable, but I'm quite certain that's 5.0.0 (20:24:25) igorw: ok, now I am sure (20:24:39) igorw: "Abstract base interface that cannot be implemented alone. Instead it must be implemented by either IteratorAggregate or Iterator." http://ch2.php.net/Traversable (20:24:50) igorw: and both of those existin since 5.0.0

          People

          • Assignee:
            Oleg Oleg [X] (Inactive)
            Reporter:
            Oleg Oleg [X] (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development