Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10444

Edit reason remains if a post gets edited by a moderator for the second time

    Details

      Description

      If a moderator edits a post that already has been edited, and the previous moderator left an edit reason this old reason gets injected into the reason field and with that automatically gets re-used for the new update. This assumes that the post is edited twice for the same reason though this usually won't be the case. I propose to change this behavior to keep the field empty by default, this way if the second moderator doesn't fill out the field the reason at least doesn't contain a reason that doesn't reflect the last change to the post.

        Issue Links

          Activity

          Hide
          nickvergessen Joas Schilling added a comment -

          I think it's much easier to clean the field if one wishes, than to copy paste the old edit reason, when you reuse it.

          Show
          nickvergessen Joas Schilling added a comment - I think it's much easier to clean the field if one wishes, than to copy paste the old edit reason, when you reuse it.
          Hide
          Erik Frèrejean Erik Frèrejean added a comment -

          How often will a post be edited for the same reason?
          If you don't intent to leave a note, one makes the edit and hits submit, as the note field is underneath the submit button the content is easily missed. Once submitted the last editor is updated but the note isn't, resulting in wrong information. Moderator `y` didn't edit the post because of the reason moderator `x` did. So moderator `y` needs to re-edit the post to correct the note. IMO the board shouldn't assume why a moderator is editing a post.

          Show
          Erik Frèrejean Erik Frèrejean added a comment - How often will a post be edited for the same reason? If you don't intent to leave a note, one makes the edit and hits submit, as the note field is underneath the submit button the content is easily missed. Once submitted the last editor is updated but the note isn't, resulting in wrong information. Moderator `y` didn't edit the post because of the reason moderator `x` did. So moderator `y` needs to re-edit the post to correct the note. IMO the board shouldn't assume why a moderator is editing a post.
          Hide
          bantu Andreas Fischer added a comment -

          Behaviour in 3.0.x should probably stay. Having only a single field for an edit reason is suboptimal in my opinion. For later versions of phpBB, a complete "history feature" that also keeps the content of a post would be great.

          Show
          bantu Andreas Fischer added a comment - Behaviour in 3.0.x should probably stay. Having only a single field for an edit reason is suboptimal in my opinion. For later versions of phpBB, a complete "history feature" that also keeps the content of a post would be great.
          Hide
          imkingdavid David King added a comment -

          I agree that the field should be wiped (I've observed this behavior before), but I also agree that we should add a post history feature in future versions that would support an edit reason for each edit. I know I saw an RFC for post edit history/post revisions but I'm not sure for what version or if there has been a ticket (a quick search didn't find one).

          Show
          imkingdavid David King added a comment - I agree that the field should be wiped (I've observed this behavior before), but I also agree that we should add a post history feature in future versions that would support an edit reason for each edit. I know I saw an RFC for post edit history/post revisions but I'm not sure for what version or if there has been a ticket (a quick search didn't find one).
          Hide
          imkingdavid David King added a comment -

          I think that this should be implemented, as it relates to the Post Revisions RFC.

          Show
          imkingdavid David King added a comment - I think that this should be implemented, as it relates to the Post Revisions RFC.

            People

            • Assignee:
              imkingdavid David King
              Reporter:
              Erik Frèrejean Erik Frèrejean
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development