Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10420

Update startup to account for PHP 5.4

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.0.9, 3.1.0-dev
    • Fix Version/s: 3.0.10-RC1
    • Component/s: None
    • Labels:
      None

      Description

      startup.php should be updated to account for the changes in PHP 5.4: http://svn.php.net/viewvc/php/php-src/branches/PHP_5_4/NEWS?view=markup#l122

      <cs278> bantu: do we not need to update this for 5.4: https://github.com/phpbb/phpbb3/blob/develop-olympus/phpBB/includes/startup.php#L101
      <bantu> cs278: no idea
      <bantu> i doubt it
      <cs278> http://svn.php.net/viewvc/php/php-src/branches/PHP_5_4/NEWS?view=markup#l122
      <igorw> yay!
      <cs278> register_globals is gone too
      <igorw> magic quotes and reg globals gone
      <cs278> we could change that if condition to be < 5.4.0-dev
      <bantu> cs278: we have to
      <bantu> or does E_CORE_ERROR continue?
      <bantu> probably now
      <bantu> t
      <cs278> bantu: ?
      <bantu> if (version_compare(PHP_VERSION, '6.0.0-dev', '>=')) { } else

      Unknown macro: { @set_magic_quotes_runtime(0); }

      <bantu> results in E_CORE_ERROR on 5.4
      <bantu> according to the page you linked
      <bantu> cs278: ?
      <bantu> am i missing something?
      <bantu> so we have to adjust startup.php
      <cs278> oh bantu I missed that
      <bantu> cs278: please create a ticket for it
      <bantu> set to 10-RC1 and blocker
      <bantu> it's very unlikely they'll revert those changes in php

        Issue Links

          Activity

          There are no comments yet on this issue.

            People

            • Assignee:
              bantu Andreas Fischer
              Reporter:
              ToonArmy Chris Smith
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development