Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10401

auth_ldap has an incorrect return value in login_ldap()

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.9
    • Fix Version/s: 3.0.11-RC1
    • Component/s: Authentication
    • Labels:
      None

      Description

      I happened to notice when I was investigating a user's problem that includes/auth/auth_ldap.php has a bad return on line 159:

      [code] return $user->lang['LDAP_NO_SERVER_CONNECTION'];[/code]

      which translates to
      [code] 'LDAP_NO_SERVER_CONNECTION' => 'Could not connect to LDAP server.',[/code]

      the login_box function is expecting an array to be returned, not a string as this file is doing on line-145:

      [code] return array(
      'status' => LOGIN_ERROR_EXTERNAL_AUTH,
      'error_msg' => 'LDAP_NO_SERVER_CONNECTION',
      'user_row' => array('user_id' => ANONYMOUS),
      );[/code]

        Attachments

          Activity

            People

            • Assignee:
              bantu Andreas Fischer
              Reporter:
              Brf Brf
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: