Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10399

Special characters aren't parsed in style component variables

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.9
    • Fix Version/s: 3.0.11-RC1
    • Component/s: Styles
    • Labels:
      None

      Description

      Template variables

      {T_THEME_PATH}

      aren't being encoded correctly when style uses directory name that requires encoding, like "rock'n_roll_silver", resulting in invalid inline css.

      Current result: ./styles/rock'n_roll_silver/theme
      But it should be: ./styles/rock%27n_roll_silver/theme

        Activity

        Hide
        Oleg Oleg [X] (Inactive) added a comment -

        https://github.com/phpbb/phpbb3/pull/394 for 3.0, merged with -s ours into develop.

        https://github.com/phpbb/phpbb3/pull/397 for 3.1.

        Merged, but https://github.com/p/phpbb3/compare/ticket%2F10399-plus and when I was testing that I found other places in acp_imagesets that are not urlencoding the paths.

        Show
        Oleg Oleg [X] (Inactive) added a comment - https://github.com/phpbb/phpbb3/pull/394 for 3.0, merged with -s ours into develop. https://github.com/phpbb/phpbb3/pull/397 for 3.1. Merged, but https://github.com/p/phpbb3/compare/ticket%2F10399-plus and when I was testing that I found other places in acp_imagesets that are not urlencoding the paths.

          People

          • Assignee:
            Oleg Oleg [X] (Inactive)
            Reporter:
            Arty Vjacheslav Trushkin
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development