Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10392

Alternate nested block loop syntax broken for auto variables

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-dev
    • Fix Version/s: 3.1.0-a1
    • Component/s: Template Engine
    • Labels:
      None

      Description

      The fully qualified block syntax has been broken by the new template engine, this syntax is used heavily in adm/style/permission_mask.html vars look like {{

      {p_mask.f_mask.S_ROW_COUNT}

      }} which compiles to <?php echo $_p_mask.f_mask_i; ?>.

        Activity

        Hide
        ToonArmy Chris Smith added a comment -

        Not sure if this is a complete fix (yes it needs tests): https://github.com/cs278/phpbb3/compare/ticket/10392

        Show
        ToonArmy Chris Smith added a comment - Not sure if this is a complete fix (yes it needs tests): https://github.com/cs278/phpbb3/compare/ticket/10392
        Hide
        ToonArmy Chris Smith added a comment -

        This fix obviously only applies to 3.1 but the tests should probably be merged into 3.0. How to go about that?

        Show
        ToonArmy Chris Smith added a comment - This fix obviously only applies to 3.1 but the tests should probably be merged into 3.0. How to go about that?
        Hide
        Oleg Oleg [X] (Inactive) added a comment -

        That happens to be rather nontrivial. https://github.com/phpbb/phpbb3/pull/351 has some work in that direction. Basically the relevant framework pieces have to be backported, then the tests have to be backported.

        Show
        Oleg Oleg [X] (Inactive) added a comment - That happens to be rather nontrivial. https://github.com/phpbb/phpbb3/pull/351 has some work in that direction. Basically the relevant framework pieces have to be backported, then the tests have to be backported.
        Hide
        brunoais brunoais added a comment -

        What are the steps to reproduce this?

        Show
        brunoais brunoais added a comment - What are the steps to reproduce this?

          People

          • Assignee:
            ToonArmy Chris Smith
            Reporter:
            ToonArmy Chris Smith
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development