Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10388

Template engine should use json_encode() to properly escape JS properties

    XMLWordPrintable

Details

    Description

      Currently the template engine (and other places) use addslashes() to escape data which is to be used in javascript, this is a poor solution and json_encode() should be employed to do the escaping.

      Attachments

        Issue Links

          depends on

          Task - A task that needs to be done. PHPBB3-10389 JSON extension should be checked in the installer

          • Major - Major loss of function.
          • Closed
          is duplicated by

          Improvement - An improvement or enhancement to an existing feature or task. PHPBB3-7582 Add JS_ prefix for tpl vars

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            People

              Marc Marc
              ToonArmy Chris Smith
              Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: