Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10349

Unit tests do not remove comments from schemas

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.9
    • Fix Version/s: 3.0.11-RC1
    • Component/s: Test Suite
    • Labels:
      None
    • Environment:
      Oracle XE 10g

      Description

      When the database is initialized for testing, the schema files aren't processed in the same way that they are by the installer. The installer strips away the comments before loading the schema. In most cases it's fine that this is done, but for Oracle, the table delimiter / is the same as a comment delimiter /* */ so the queries aren't correctly loaded for execution, resulting in SQL errors due to non-queries being executed.

        Issue Links

          Activity

          Hide
          naderman Nils Adermann added a comment - - edited

          Maybe we should fix the schema files so this is no longer necessary rather than changing the tests?

          Show
          naderman Nils Adermann added a comment - - edited Maybe we should fix the schema files so this is no longer necessary rather than changing the tests?
          Hide
          Noxwizard Patrick Webster added a comment -

          As per the comments in the pull request and IRC, the functions have been merged together, added to the unit tests, and replaced in the installer. I've tested this on all of the DMBSs that we use.

          Show
          Noxwizard Patrick Webster added a comment - As per the comments in the pull request and IRC, the functions have been merged together, added to the unit tests, and replaced in the installer. I've tested this on all of the DMBSs that we use.

            People

            • Assignee:
              Oleg Oleg [X] (Inactive)
              Reporter:
              Noxwizard Patrick Webster
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development