Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10315

Radio Buttons in ACP are clipped in Safari - Fix suggested

    Details

    • Type: Improvement
    • Status: Unverified Fix
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.0.9
    • Fix Version/s: 3.0.10-RC1
    • Component/s: ACP
    • Labels:
      None

      Description

      Since Safari updated to v5.1, for whatever reason, Radio Buttons in the ACP now appear to be cut off along the top. See attached image.

      Anyway, a simple fix is to add a tiny bit of margin as

      margin-top:1px;

      to the input.radio style element in admin.css

      This would not only repair the issue in Safari 5.1, but would be a harmless and un-noticed effect in all other browsers.

        Activity

        Hide
        nickvergessen Joas Schilling added a comment -

        Can't reproduce with Safari 5.1.7534.50 on Windows7
        Will try to find a mac for testing.

        Show
        nickvergessen Joas Schilling added a comment - Can't reproduce with Safari 5.1.7534.50 on Windows7 Will try to find a mac for testing.
        Hide
        nickvergessen Joas Schilling added a comment -

        I changed to margin-top to margin: 1px 0; (so top and bottom) to fix the look of the options a bit.

        Show
        nickvergessen Joas Schilling added a comment - I changed to margin-top to margin: 1px 0; (so top and bottom) to fix the look of the options a bit.
        Hide
        Oleg Oleg [X] (Inactive) added a comment -

        I'm seeing this on firefox 3.6.18 on freebsd.

        The proposed 1px fix does not work for me, but changing 1px to 2px does fix the radio buttons.

        Show
        Oleg Oleg [X] (Inactive) added a comment - I'm seeing this on firefox 3.6.18 on freebsd. The proposed 1px fix does not work for me, but changing 1px to 2px does fix the radio buttons.
        Hide
        Oleg Oleg [X] (Inactive) added a comment -

        Firefox 3.6.18 Freebsd radio buttons - without patch (broken)

        Show
        Oleg Oleg [X] (Inactive) added a comment - Firefox 3.6.18 Freebsd radio buttons - without patch (broken)
        Hide
        Oleg Oleg [X] (Inactive) added a comment - - edited

        I'm not really seeing issues with select boxes on my system, but either 1px or 2px for selects looks acceptable.

        I can provide screenshots if needed.

        Show
        Oleg Oleg [X] (Inactive) added a comment - - edited I'm not really seeing issues with select boxes on my system, but either 1px or 2px for selects looks acceptable. I can provide screenshots if needed.
        Hide
        nickvergessen Joas Schilling added a comment -

        Changed the patch to use 2px

        Show
        nickvergessen Joas Schilling added a comment - Changed the patch to use 2px

          People

          • Assignee:
            nickvergessen Joas Schilling
            Reporter:
            VSE Matt Friedman
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development