Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10293

Jumpbox allows jumping to invalid forums in prosilver

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.9
    • Fix Version/s: 3.0.10-RC1
    • Component/s: Styles
    • Labels:
      None
    • Environment:
      Safari 5.0.5

      Description

      There is a critical error in the jumpbox javascript when selecting a forum via keyboard and pressing Enter:

      TypeError: Result of expression 'document.jumpbox' [undefined] is not an object.

      This means that it is possible to go to invalid forums (-1)

        Activity

        Hide
        Oleg Oleg [X] (Inactive) added a comment -

        Please include problem descriptions and steps to reproduce them in the tickets.

        We have to verify there is actually a bug in each of the bug tickets, and verify the fix as well. I am finding that I have to figure out what the bug is from reading your patches.

        For example, problem description for this ticket might read:

        On viewforum page, it is possible to "jump" to an invalid forum (-1) by selecting "Select a forum" option in the forum jumpbox and pressing Enter.

        Specifically regarding this ticket, the usual usage of jumpbox by simply choosing the desired forum (and relying on onchange event handler to issue the redirect) does not redirect to invalid forums.

        Show
        Oleg Oleg [X] (Inactive) added a comment - Please include problem descriptions and steps to reproduce them in the tickets. We have to verify there is actually a bug in each of the bug tickets, and verify the fix as well. I am finding that I have to figure out what the bug is from reading your patches. For example, problem description for this ticket might read: On viewforum page, it is possible to "jump" to an invalid forum (-1) by selecting "Select a forum" option in the forum jumpbox and pressing Enter. Specifically regarding this ticket, the usual usage of jumpbox by simply choosing the desired forum (and relying on onchange event handler to issue the redirect) does not redirect to invalid forums.
        Hide
        Oleg Oleg [X] (Inactive) added a comment - - edited

        subsilver has similar code, I would venture that it would be affected as well.

        Edit: I see, subsilver uses a name=jumpbox while prosilver uses id=jumpbox.

        It would be nice to have the same code for subsilver and prosilver, since there is not in my mind a good reason to do this operation in two different ways. But subsilver is technically is not broken so maybe we should not "fix" it.

        Show
        Oleg Oleg [X] (Inactive) added a comment - - edited subsilver has similar code, I would venture that it would be affected as well. Edit: I see, subsilver uses a name=jumpbox while prosilver uses id=jumpbox. It would be nice to have the same code for subsilver and prosilver, since there is not in my mind a good reason to do this operation in two different ways. But subsilver is technically is not broken so maybe we should not "fix" it.

          People

          • Assignee:
            Oleg Oleg [X] (Inactive)
            Reporter:
            callum95 callum95
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development