Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10267

Missing strlen() on $table_prefix in db tools index name length check

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.9
    • Fix Version/s: 3.0.10-RC1
    • Component/s: None
    • Labels:
      None

      Description

      		$table_prefix = substr(CONFIG_TABLE, 0, -6); // strlen(config)
      		if (strlen($table_name . $index_name) - strlen($table_prefix) > 24)
      		{
      			$max_length = $table_prefix + 24;
      			trigger_error("Index name '{$table_name}_$index_name' on table '$table_name' is too long. The maximum is $max_length characters.", E_USER_ERROR);
      		}

      $max_length = $table_prefix + 24;

      Should be strlen($table_prefix) here.

        Issue Links

          Activity

          There are no comments yet on this issue.

            People

            • Assignee:
              bantu Andreas Fischer
              Reporter:
              bantu Andreas Fischer
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development