Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10263

Add phpbb_version_compare() wrapper for version_compare()

    Details

    • Type: Improvement
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.9
    • Fix Version/s: 3.0.10-RC1
    • Component/s: None
    • Labels:
      None

      Description

      [23:26:37] <nickvergessen> can someone confirm var_dump(version_compare('1.1.0-A2', '1.1.0-B1')); == 1 and var_dump(version_compare('1.1.0-a2', '1.1.0-b1')); == -1
      [23:28:03] <igorw> yep
      [23:28:11] <nickvergessen> stupid
      [23:31:26] <bantu> that's interessting
      [23:31:37] <bantu> *interesting
      [23:31:46] <bantu> and is the reason why we have strtolower() in our checks
      [23:32:44] <bantu> hmm
      [23:32:57] <bantu> maybe we should have phpbb_version_compare() as a wrapper with proper documentation
      [23:33:09] <bantu> such tiny things are rather annoying
      [23:33:31] <naderman> bantu: create a ticket so we don't forget?

        Activity

        Hide
        Oleg Oleg [X] (Inactive) added a comment -

        version_compare should really not be used for anything other than php version numbers if any sort of sanity is desired.

        Show
        Oleg Oleg [X] (Inactive) added a comment - version_compare should really not be used for anything other than php version numbers if any sort of sanity is desired.
        Hide
        bantu Andreas Fischer added a comment - - edited

        version_compare() works on PHP-standardized strings and we actually planned to make our versions version_compare() compatible (i.e. PHP-standardized) but apparently failed.

        Show
        bantu Andreas Fischer added a comment - - edited version_compare() works on PHP-standardized strings and we actually planned to make our versions version_compare() compatible (i.e. PHP-standardized) but apparently failed.

          People

          • Assignee:
            bantu Andreas Fischer
            Reporter:
            bantu Andreas Fischer
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development