Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10223

Updater references startup.php from board path

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.0.9-RC2
    • Fix Version/s: 3.0.9-RC3
    • Component/s: Update system
    • Labels:
      None

      Description

      The updater attempts to load /includes/startup.php from the board path and not the installer path. For versions < 3.0.9-RC2, this will result in an error since the file hasn't been added yet. For those versions, it will need to be loaded from /install/update/new/includes/ instead.

        Issue Links

          Activity

          Hide
          nickvergessen Joas Schilling added a comment -

          It should always use $this->new_location = $phpbb_root_path . 'install/update/new/';
          if that file is available else use $phpbb_root_path.

          As this is already done for some files, maybe we could write a function for that?

          Show
          nickvergessen Joas Schilling added a comment - It should always use $this->new_location = $phpbb_root_path . 'install/update/new/'; if that file is available else use $phpbb_root_path. As this is already done for some files, maybe we could write a function for that?
          Hide
          bantu Andreas Fischer added a comment -

          Maybe write an include wrapper, this might not be the last time. ...

          Show
          bantu Andreas Fischer added a comment - Maybe write an include wrapper, this might not be the last time. ...
          Hide
          naderman Nils Adermann added a comment -

          Accidently used spaces instead of tabs.

          Show
          naderman Nils Adermann added a comment - Accidently used spaces instead of tabs.
          Hide
          naderman Nils Adermann added a comment -

          Naming conflict on automatic update.

          Show
          naderman Nils Adermann added a comment - Naming conflict on automatic update.
          Hide
          naderman Nils Adermann added a comment -

          Here we go again ...

          Show
          naderman Nils Adermann added a comment - Here we go again ...

            People

            • Assignee:
              naderman Nils Adermann
              Reporter:
              Noxwizard Patrick Webster
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development