Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10204

Package build tool does not detect binary file changes

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.0.8
    • Fix Version/s: 3.0.9-RC1
    • Component/s: Build System, Update system
    • Labels:
      None

      Description

      The package.php tool does not detect binary file changes. So changed image files are not in update packages. This is caused by a regular expression that does not match directory names like release-3.0.8 because it does not allow dots.

      preg_match('/^Binary files ' . $package_name . '\/(.*) and [a-z0-9_-]+\/\1 differ/i', $line, $match)

        Attachments

          Activity

            People

            • Assignee:
              naderman Nils Adermann
              Reporter:
              naderman Nils Adermann
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: